search

Locastic / ApiPlatformTranslationBundle

Translation bundle for ApiPlatform based on Sylius translation
MIT License
85 stars 28 forks source link

orm 3.0 support #68

Closed konradkozaczenko closed 3 months ago

paullla commented 3 months ago

Hey @konradkozaczenko thank you for this PR. Some tests are failing, can you take a look at them and then we can merge?

konradkozaczenko commented 3 months ago

Hey @konradkozaczenko thank you for this PR. Some tests are failing, can you take a look at them and then we can merge?

Hi, doctrine/orm 3.0 is not compatible with php8.0. I've updated php requirement in composer.json but I guess that's all I can do :(

paullla commented 3 months ago

For this version we can remove php 8.0 from checks since it is no longer supported and add php 8.3: https://github.com/Locastic/ApiPlatformTranslationBundle/blob/master/.github/workflows/phpunit.yml#L14

paullla commented 3 months ago

@konradkozaczenko thank you, I'll merge this and handle Scrutinizer issue in the next pr :)