LockerProject / Locker

Locker - the "me" platform
http://lockerproject.org/
BSD 3-Clause "New" or "Revised" License
1.07k stars 123 forks source link

Different icons used for Github in different places #845

Open mdz opened 12 years ago

mdz commented 12 years ago

On the side nav and the home page, it's a gray "g". In the contacts app, it's a cat.

trentlarson commented 12 years ago

There's the "g": https://github.com/LockerProject/Locker/blob/master/Apps/dashboardv3/static/img/icons/32px/github.png (... and 16px and 24px and icons-old versions)

... and the octocat https://github.com/LockerProject/Locker/blob/master/Apps/MergedContacts/static/img/social-icons/32px/github.png (... and 16px and 24px versions)

... and the octocat silhouette: https://github.com/LockerProject/Locker/blob/master/Apps/LinkaLatte/static/img/github.png https://github.com/LockerProject/Locker/blob/master/Apps/dashboardv3/static/img/www.addictedtocoffee.de/github.png (... and others in that directory)

Which do you prefer? (I vote for octocat of any variety. :-)

And do we change those specific App (LinkaLatte and addictedtocoffee.de) versions as well?

(I assume I'd do a pull request to submit a fix.)

mdz commented 12 years ago

+1 on octocat! :-) I'm indifferent on precisely which one, and defer to @merc3po on the particulars

merc3po commented 12 years ago

All the icons on the site (apart from the app) are the gray "g", and appear in a lot of places like the header of every app, the app gallery, etc. I'd rather not start changing them on the site to match the app. (The cat is cuter and when we refactor the frontend business we can sub the gray g out for it, though.)