search

LocusEnergy / ember-sparkles

Collection of composable D3 components built with ember-d3-helpers
http://locusenergy.github.io/ember-sparkles/#/line-chart
MIT License
56 stars 9 forks source link

Example not working with Ember 2.13 #61

Open BryanHunt opened 7 years ago

BryanHunt commented 7 years ago

I'm trying to get your example line chart working and I'm using Ember 2.13. I think I figured out all of the dependencies, but now I'm getting this exception:

Error: let not found, and the catch-all block handler didn't handle it
    at Object.debugAssert [as assert] (http://localhost:4200/assets/vendor.js:16550:19)
    at Blocks.compile (http://localhost:4200/assets/vendor.js:16254:241)
    at http://localhost:4200/assets/vendor.js:16249:3224
    at Compilers.compile (http://localhost:4200/assets/vendor.js:16249:531)
    at compileStatement (http://localhost:4200/assets/vendor.js:16248:8728)
    at http://localhost:4200/assets/vendor.js:16248:727
    at Array.forEach (native)
    at WrappedBuilder.compile (http://localhost:4200/assets/vendor.js:16248:692)
    at ComponentLayoutBuilder.compile (http://localhost:4200/assets/vendor.js:16221:715)
    at Object.compileLayout (http://localhost:4200/assets/vendor.js:16221:280)
defaultDispatch @ ember.debug.js:19822
dispatchError @ ember.debug.js:19801
invokeWithOnError @ ember.debug.js:2204
flush @ ember.debug.js:2260
flush @ ember.debug.js:2384
end @ ember.debug.js:2454
run @ ember.debug.js:2568
join @ ember.debug.js:2599
run.join @ ember.debug.js:24497
(anonymous) @ ember.debug.js:24560
mightThrow @ jquery.js:3583
process @ jquery.js:3651
ghost commented 7 years ago

Thanks for reporting this, @BryanHunt. I am pretty busy this week but I will be able to take a look over the weekend if not before.

BryanHunt commented 7 years ago

Ping

ghost commented 7 years ago

Hi - I'm sorry for the delay, I'll take a look at this today.

On Sun, Jun 11, 2017 at 8:23 AM Bryan Hunt notifications@github.com wrote:

Ping

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/LocusEnergy/ember-sparkles/issues/61#issuecomment-307636061, or mute the thread https://github.com/notifications/unsubscribe-auth/AC2v9whnSx_3-yrvCKXegZ7YWR5Hzsycks5sDAZrgaJpZM4NhoOL .

ghost commented 7 years ago

@BryanHunt can you please share your sample app with me?

yarigpopov commented 7 years ago

@BryanHunt have you installed ember-let?

BryanHunt commented 7 years ago

Installing ember-let fixes the problem.

ghost commented 7 years ago

@chilicoder thank you for mentioning this. It sounds like it provides a fix! I'm sorry I haven't been active on this project lately, I'm glad that you were able to get this working. I will try updating the dependency structure so that the external library is not required.