search

LocusEnergy / ember-sparkles

Collection of composable D3 components built with ember-d3-helpers
http://locusenergy.github.io/ember-sparkles/#/line-chart
MIT License
56 stars 9 forks source link

Update the library for ember 2.17 #63

Closed yarigpopov closed 6 years ago

yarigpopov commented 6 years ago

Hi!

Here is my update for the library to make it possible to use from Ember 2.16+ versions

yarigpopov commented 6 years ago

Ok.. here I have to pause(.
tests are red due to the error TypeError: compileArgs is not a function which is a problem for ember-let library (see issue https://github.com/thefrontside/ember-let/issues/44 for details) We need PR https://github.com/thefrontside/ember-let/pull/43 to close to make tests green.

yarigpopov commented 6 years ago

small update. We need this PR to be merged https://github.com/thefrontside/ember-let/pull/45

ghost commented 6 years ago

I will merge this today

ghost commented 6 years ago

I merged with the failing tests and added the new ember-let version (as well as the updated ember-d3-helpers). Travis is failing because we don't have yarn support, it looks like - would you be up for taking a look? I don't have much more time to spend on this today. As mentioned in d3 helpers - would be happy to add you as a maintainer, if you are interested! I really appreciate the pull requests you've been contributing.

yarigpopov commented 6 years ago

Hi @zigahertz Thank you for the merge! Also good news from ember-let repo!, Guys merged PR for ember 2.15+ support tonight (but still wait while it will be published in npm).

I will wait while ember-let 0.7 will appear in npm and then proceed with fixing travis CI builds.

I really appreciate your affords for this library and also forember-d3-helpers. Would be nice for me to be included in maintainers, since I rely on them in my current projects.