search

Lodestone-Team / lodestone_core

The backend for Lodestone, A free, open source server hosting tool for Minecraft and other multiplayers
https://www.lodestone.cc/
GNU Affero General Public License v3.0
59 stars 6 forks source link

Subprocess is "detached" when a non utf-8 character is emitted by it #144

Closed CheatCod closed 1 year ago

CheatCod commented 1 year ago

Description

If a subprocess managed by lodestone emits a non utf-8 character, an attempt to read will fail and lodestone will assume the process has existed while the process is still running.

Steps to reproduce (optional)

CheatCod commented 1 year ago

Fixed in https://github.com/Lodestone-Team/lodestone_core/commit/d6aaf4c2c4e24af9feca63f59f24bc31660be2eb

phant0m2290 commented 1 year ago

it seems to only happen with already created instances. when i start a newly created instance it wont detach and works fine. and for some reason with only that instance it seems to be fixed. even when i restart the core. but not for the others.