Closed adam-stanek closed 3 years ago
@adam-stanek Would you mind updating your PR with the latest from main? Once the lodestone-filesystem-publisher
and lodestone-email-publisher
DockerHub repo builds complete, I'd like to pull your branch and play with it for a bit before I merge.
@dskaggs Sorry update with what? There are no conflicts.
If you want to use tags here, sure, I can do that, but you have to build them first :)
Right. There aren't any conflicts. I would just like to pull your branch and play with it a bit but would like the tag changes that I did in the other PR included as well. So if you could merge the latest from main into your branch and push your branch up again, that would give me a branch with both our changes that I could test with before merging your PR.
Apologies for the confusion. I'm just trying to be careful before we update the compose file in main branch that other people might pull down.
@adam-stanek Disregard above. I pulled your branch and ran docker-compose up
locally. Glad I did b/c I found that I'd mis-named the DockerHub repo and the compose file fails. Fixing that now and it should be merged in a little bit.
I have updated docker-compose with changes required for newly built publisher images
I have switched the storage image too, because with fs publisher split, we can now use official minio image.
Please note that even though I have prepared the setup for email publisher, the application itself still doesn't work. The functionality has not been fully implemented. It is able to read the e-mails, upload them, but there is no notification of the processing stack: https://github.com/LodestoneHQ/lodestone-publisher/blob/main/pkg/watch/email.go#L249. I have prepared the build and orchestration though, so it should be ready once it is implemented.