search

Log1x / acf-composer

Compose ACF Fields, Blocks, Widgets, and Option Pages with ACF Builder on Sage 10.
https://github.com/Log1x/acf-composer
MIT License
419 stars 57 forks source link

❤️ feat req: Add support for vinkla/extended-acf #167

Closed chrillep closed 7 months ago

chrillep commented 1 year ago

Would there be any benefit to swithing to extended-acf, since acf-builder does not seem to be maintained.

refs

Log1x commented 1 year ago

I wouldn't switch because that'd involve a massive refactor for people wanting to upgrade, but I wouldn't be against supporting both. Extended looks really solid.

ACF Builder isn't as active as I wish it was but it also doesn't really need to be. By design, there's not much else to do to it right now.

How I could see this working is returning the Extended ACF fields in an array and checking if the first item on the array is an instance of Extended\ACF\Fields\Field and if so, looping the fields and registering them with Extended ACF's helpers instead.

chrillep commented 1 year ago

no, youre right. I just went for switching thinking it would be a smaller refactor. But as you pointed vinkla/extended-acf uses classes, so the instanceof approach seems maintainable. ill change the title description to "support vinkla/extended-acf"

Log1x commented 7 months ago

I've thought about this and while Extended ACF is great and I wish I would've known about it sooner, it simply does not fit with ACF Composer's current workflow and would be too much to maintain/document at the moment.