Issue with `addSelect` Method Returning Incorrect 'value' for Numeric or Single-Character Choices

retoolstack commented 7 months ago

Update Solved Please refer to

Summary of the Problem:

The addSelect method in ACF Composer/Builder is exhibiting unexpected behavior when handling choices that are either numeric or consist of a single non-whitespace character. Normally, this method should return an array with distinct 'value' and 'label' keys for each choice. However, when the choice key is a single character or a number, the method incorrectly returns the 'label' text as the 'value', rather than the actual key.

        ->addSelect('select_field', [
            'label' => 'Select Field',
            'choices' => [
                '1' => 'choice1',
                '2' => 'choice2'
            ],
            'return_format' => 'array',
        ])

Observed Behavior:

With numeric (1, 2, 35) or single non-whitespace character keys (like '1', '2', or 'a'), both 'value' and 'label' in the resulting array are set to the 'label' text.
```
// Example of Incorrect Behavior
"select_field" => array:2 [
  "value" => "choice2"
  "label" => "choice2"
]
```

Expected Behavior:

The 'value' should correctly reflect the key, and 'label' should be the corresponding text.

// Example of Expected Correct Behavior
"select_field" => array:2 [
  "value" => "2"
  "label" => "choice2"
]

Workaround Observed:

Adding whitespace or using keys with more than one character (like ' 1' or '_4') results in the correct behavior.

// Example with Whitespace / Extra Characters
' 1' => 'choice1',   // Works correctly
'_4' => 'choice4',   // Works correctly
'2' => 'choice2',     // Does not work
3 => 'choice3',       // Does not work
35 => 'choice35'       // Does not work

This issue impacts the functionality of the addSelect method, especially in cases where numeric or single-character keys are essential. I tested ACF plugin directly as well and when using acf (not composer) the fields do not have this issue. indicating that this bug is specific to ACF Composer/Builder

The ticket aims to resolve this inconsistency, ensuring that the method returns correct 'value' and 'label' pairs for all types of keys.

mike-sheppard commented 7 months ago

hey @retoolstack it looks like you might be bumping into this issue: https://github.com/StoutLogic/acf-builder/issues/83 ? If not, it'd probably be worth opening a new issue on https://github.com/StoutLogic/acf-builder/

retoolstack commented 7 months ago

Solved Closing This Ticket

hey @retoolstack it looks like you might be bumping into this issue: StoutLogic/acf-builder#83 ? If not, it'd probably be worth opening a new issue on https://github.com/StoutLogic/acf-builder/

Thanks @mike-sheppard

retoolstack commented 7 months ago

yeah that looks like that will solve it i will test now appreciate it I did search the tickets on composer but didn't think to check builder

Log1x / acf-composer