search

Log1x / acf-composer

Compose ACF Fields, Blocks, Widgets, and Option Pages with ACF Builder on Sage 10.
https://github.com/Log1x/acf-composer
MIT License
419 stars 57 forks source link

Native type hinting #206

Closed codepuncher closed 7 months ago

codepuncher commented 7 months ago

Native PHP type hints are used heavily in our agencies development instead of docblocks. Unfortunately, we are unable to use them with public function assets(array $block) since it is incompatible with Log1x\AcfComposer\Block::assets($block). Do you have any plans to update the codebase to support native types?

Happy to contribute this if that is acceptable!

Thanks

Log1x commented 7 months ago

I'd like too but I also want to avoid forcing people to update classes. I'm not against getting it in early for assets() in particular though.

codepuncher commented 7 months ago

I've submitted a PR just for assets() then!