Remove lock files - Githubissues

Log1x / filament-starter

A beautiful starting point for your next TALL stack project using Filament. ⚡

https://github.com/Log1x/filament-starter

MIT License

368 stars 55 forks source link

Closed madalinignisca closed 5 months ago

madalinignisca commented 5 months ago

As this is a project template, it must not have composer.lock and yarn.lock files.

Log1x commented 5 months ago

Hi!

I agree with you, but in this scenario, I opted to intentionally commit them:

I don't want to add them to .gitignore as they should otherwise be committed in your own project.
I don't want to dance around them when updating this repo with them not being ignored.
I like to check that everything is working as intended each time I bump dependencies for this repo.
Dependabot wouldn't work.

Hopefully this makes sense.

Log1x commented 5 months ago

Went ahead and removed them for now.