Closed mike-sheppard closed 3 years ago
@mike-sheppard I have a pull request in for this issue ( #39 ) already. I couldn't quite figure out what the filter was doing so I just removed it, and everything seems to be working as usual again, but perhaps that isn't the best approach. It got me where I needed to be for the time being at least.
Thanks @jellycode I did see that PR, nice one! I think the idea behind it is to exclude a bunch of the default nav items class bloat, which I'm all for! I'll pop a PR over shortly that preserves this + custom classes :)
@Log1x thank you for your effort!
Is there any plan for releasing that anytime soon?
First of all, thanks for another great package! I would like to know the same about the classes filter, right now all my custom classes are excluded in the output. Thanks!
Hey @Twansparant - for the time being I switched my projects to install navi as dev-master
Its an ugly solution but does the job for the time being.
Hi @kamilgrzegorczyk, thanks that's what I ended up doing too!
release pushed β sorry for the delay.
Thank you very much @Log1x !
Hey @Log1x! ππ»
It seems custom classes added to nav items aren't being added to
$item->classes
.Had a quick scan through the code and noticed this is excluding everything except what's in the exclusion list? Unless I'm misreading it.
https://github.com/Log1x/navi/blob/master/src/MenuBuilder.php#L90-L95
Excluded classes (however they're being allowed). Not sure if this is intentional and simply a typo in the comment: https://github.com/Log1x/navi/blob/master/src/MenuBuilder.php#L37-L50
I'll try debugging a bit later on and pop a PR over if I can fix, just thought I'd submit this issue in case you know of a solution off the top of your head.
Cheers!