search

Log4s / log4s

High-performance SLF4J wrapper for Scala.
Other
171 stars 25 forks source link

Resolve Travis concurrent-test issue #39

Closed sarahgerweck closed 5 years ago

sarahgerweck commented 5 years ago

There's a longstanding issue where Travis builds have their tests fail, typically with this message:

org.scalajs.testcommon.RPCCore$RPCException: java.lang.IllegalStateException: Can't have multiple test appenders

It's not clear exactly what causes this. Commit 06f5525e6eaef78194e42883d4a20076158c8c9a was an attempt to prevent duplicate initialization, but it didn't work. It's possible this is a Scala.js bug of some kind that never occurs on the JDK.

Any proposed solution here would need to ensure that the functionality of +test in the SBT shell works as well. (E.g., skipping initialization altogether will cause that to fail.)

sarahgerweck commented 5 years ago

Note @rossabaker, I think this is fixed (properly) now.

rossabaker commented 5 years ago

:tada: The fix makes sense, and Travis is happy.