search

Log4s / log4s

High-performance SLF4J wrapper for Scala.
Other
171 stars 25 forks source link

Scala 2.13.1 #45

Closed sullis closed 4 years ago

rossabaker commented 4 years ago

Looks like this breaks the site generation on 2.13.1 somehow.

sarahgerweck commented 4 years ago

It actually doesn’t compile:

[error] /home/travis/build/Log4s/log4s/core/js/src/main/scala/org/log4s/log4sjs/Log4s.scala:13:16: reference to Log4sConfig is ambiguous;
[error] it is both defined in trait package-platform and available as object Log4sConfig in package log4sjs
[error]   val Config = Log4sConfig

This might be easy to fix, but it should retain binary compatibility. I won’t have time to look at it right away unless it‘s affecting 2.13.1 users (which seems unlikely).

rossabaker commented 4 years ago

Yes, my mistake. I looked too hastily and didn't notice test makeSite were the same step.

We might consider adding to Scala Steward, which would:

  1. Automate PRs like this if they work, including alerting us to problems when we break.
  2. Keep plugins like sbt-mima current so we have the latest tools to verify compatibility of the fix.
sullis commented 4 years ago

obsolete.

sullis commented 4 years ago

superseded by https://github.com/Log4s/log4s/pull/50