Closed rossabaker closed 3 years ago
Going to wait for #50 to build and give @sarahgerweck a chance to weigh in on the versioning or stop the presses. I'll aim to release tomorrow.
I'm happy enough with calling this a 1.9. @rossabaker if you want to finish releasing this please go ahead.
I've been trying to find time to catch up here but have a lot going on right now. Thanks for helping get this done.
I haven't forgotten. I've hit a snag on sbt release
with MiMa. We can't run anything less than mima-0.6.1 on the upgraded SBT, and modern versions uncover some problems. Investigating:
[error] Log4s: Failed binary compatibility check against org.log4s:log4s_2.12:1.3.6! Found 16 potential problems (filtered 4)
[error] * static method clone()java.lang.Object in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.clone")
[error] * static method seq()scala.collection.Map in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.seq")
[error] * static method empty()scala.collection.Map in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.empty")
[error] * static method ++(scala.collection.GenTraversableOnce)scala.collection.Map in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.++")
[error] * static method +(scala.Tuple2,scala.Tuple2,scala.collection.Seq)scala.collection.Map in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.+")
[error] * static method updated(java.lang.Object,java.lang.Object)scala.collection.Map in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.updated")
[error] * static method --(scala.collection.GenTraversableOnce)scala.collection.generic.Subtractable in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.--")
[error] * static method -(java.lang.Object,java.lang.Object,scala.collection.Seq)scala.collection.generic.Subtractable in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.-")
[error] * static method andThen(scala.Function1)scala.Function1 in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.andThen")
[error] * static method seq()scala.collection.mutable.Iterable in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.seq")
[error] * static method seq()scala.collection.Iterable in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.seq")
[error] * static method seq()scala.collection.mutable.Traversable in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.seq")
[error] * static method seq()scala.collection.Traversable in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.seq")
[error] * static method view(Int,Int)scala.collection.TraversableView in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.view")
[error] * static method view()scala.collection.TraversableView in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.view")
[error] * static method filterNot(scala.Function1)java.lang.Object in class org.log4s.MDC does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("org.log4s.MDC.filterNot")
The upgrade from Scala 2.12.6 to 2.12.8 in log4s-1.7.0 is responsible for the above error. It's not new, and nobody has complained, so I'm going to filter them to finish this release, and we can discuss what to do about it later.
@rossabaker ping me if this is getting too onerous. I probably couldn’t get into this until next week though.
I found that those are known false positives. I've worked around that, and am now wrestling with BouncyCastle. I also upgraded sbt-pgp. I think there is light at the end of this tunnel.
Success! I snuck in these two commits, which I hope are uncontroversial:
Strictly speaking for semver, this could be a patch release, but I wanted to get people's attention since Scala 2.10 and Scala.js 0.6 are dropped. And since it's non-breaking for what does publish, I didn't want to go as far bumping the major version. So I compromised: minor bump.