Log4s / log4s

High-performance SLF4J wrapper for Scala.
Other
171 stars 25 forks source link

Support scala.js on Scala 3 #64

Closed rossabaker closed 3 years ago

rossabaker commented 3 years ago

Follow-up to #63. Moved the package-platforms to scala-2, because we removed the package object in Scala 3. In Scala 3, we can freely mix top-level definitions, so don't need the empty JVM stub anymore.

I'll plan to release this as another milestone.

/cc @Kevin-Lee

kevin-lee commented 3 years ago

Great! Thank you! 👍

rossabaker commented 3 years ago

This is closer, but I get the following on ++3.0.0-RC2 test (hacking Dependencies.scala is necessary until #73 is merged):

[error] Referring to non-existent method scala.scalajs.js.$bar$.UnionOps(java.lang.Object)java.lang.Object
[error]   called from org.log4s.log4sjs.FunctionalType.fromDynamicType(scala.scalajs.js.$bar)scala.scalajs.js.Any
[error]   called from static org.log4s.log4sjs.FunctionalType.org$log4s$log4sjs$FunctionalType$Provider$$$_$$lessinit$greater$$anonfun$4(org.log4s.log4sjs.FunctionalType,scala.scalajs.js.$bar)scala.scalajs.js.Any
[error]   called from constructor org.log4s.log4sjs.FunctionalType$Provider$.<init>(org.log4s.log4sjs.FunctionalType)void
[error]   called from org.log4s.log4sjs.FunctionalType.Provider()org.log4s.log4sjs.FunctionalType$Provider$
[error]   called from org.log4s.PlatformInit$.init()void
[error]   called from org.log4s.LoggerInit.$init$()void
[error]   called from constructor org.log4s.GetLoggerSpec.<init>()void
[error]   called from static constructor org.log4s.GetLoggerSpec.<stinit>()void
[error]   called from core module analyzer

I'm not bothering with 3.0.0-RC1, which is old news and doesn't have the scalatestplus-scalacheck library.

rossabaker commented 3 years ago

I'd still like to get this one done before Scala 3 is out.

rossabaker commented 3 years ago

Fixed by #75.