search

Logan1x / Python-Scripts

Collection of Various Python Script's.💻
https://logan1x.github.io/Python-Scripts/
MIT License
306 stars 147 forks source link

Redesign The Repo #2

Closed Logan1x closed 7 years ago

Logan1x commented 7 years ago

Script in the folder is not looking good to me, If you can put them outside of folder here, this would look more fine.

Add Your name in readme.md after contributing😊.

KayvanMazaheri commented 7 years ago

I'm willing to work on this.
can you assign it to me?

Logan1x commented 7 years ago

Sure @KayvanMazaheri

Logan1x commented 7 years ago

selection_003 i am having bit problem do you have any idea about this?

KayvanMazaheri commented 7 years ago

Not Really ! :smile:

Logan1x commented 7 years ago

It's Okay. I am looking into it.

TheCodeArtist commented 7 years ago

if you can put them outside of folder here, this would look more fine. While moving the py scripts to the root of the repo, what about the rest of the files (README and LICENSE) in the directories?

Logan1x commented 7 years ago

LICENSE will be commom for all and one readme.md file will consist of all the project description @TheCodeArtist

pradyunsg commented 7 years ago

@Logan1x You cannot assign an issue to someone who does not have commit access to the repository. :)

pradyunsg commented 7 years ago

I would be interested in taking this on too.

Logan1x commented 7 years ago

Can you provide source for this @pradyunsg By commit access you mean collaborator ?

You cannot assign an issue to someone who does not have commit access to the repository. :)

Logan1x commented 7 years ago

Sorry for this @pradyunsg

I would be interested in taking this on too.

this issue is alredy working by @KayvanMazaheri
you both can consult and divide work if you want to ...

pradyunsg commented 7 years ago

By commit access you mean collaborator ?

Yep. :)

pradyunsg commented 7 years ago

this issue is alredy working by

Cool. No issues. :)

Logan1x commented 7 years ago

@pradyunsg source please

Yep. :)

pradyunsg commented 7 years ago

Uhm... experience?

Anyway, a google search for "GitHub assign issues" leads to https://help.github.com/articles/assigning-issues-and-pull-requests-to-other-github-users/ where you can see that in the tips section it says:

If you have write access to a repository, you can assign issues and pull requests to yourself, collaborators on personal projects, or members of your organization with read permissions on the repository.

danishprakash commented 7 years ago

This still doesn't looks assigned to someone to me, can someone assign me?

Logan1x commented 7 years ago

@pradyunsg are you refering to this line...

If you have write access to a repository, you can assign issues and pull requests to yourself, collaborators on personal projects, or members of your organization with read permissions on the repository.

if you are then it says if you have write access then you can add yourself. collaborators, and other members with read permission...so no need to be collaborator.

Logan1x commented 7 years ago

@prakashdanish It's already assigned to someone else due to some error i am not able to add him as assignee😞. You have a good profile page 😊.

pradyunsg commented 7 years ago

@Logan1x

members of your organization

This is a personal project, not an organisation's project; which is why you can't do that.

collaborators on personal projects

If you want to add @KayvanMazaheri (or whoever) as the assignee, they need to be a collaborator (i.e. able to push commits to this repository). If you're not comfortable with that, feel free to just mention that that person is going to tackle that issue in the OP -- the description of the issue.

if you are then it says if you have write access then you can add yourself. collaborators, and other members with read permission...so no need to be collaborator.

I think I should mention that this comes across as snarky; it is not really nice to be on the receiving end of such a comment -- emphasis added, quoted content modified to suit your position, almost sarcastic -- it feels like you're saying I can't read. I was trying to help you here but now I don't think it's a good use of my free time to do so.

I assume, in good faith, this was not your intention but please be careful about what the tone of your comments are in the future.

pradyunsg commented 7 years ago

As an aside, putting all the scripts in a bin directory is also an idea that someone might want to explore.

pradyunsg commented 7 years ago

you should focus on org

Oh well... Please don't tell people what to do with their own time. There's a better way to say let someone with less experience do this.

That's about all I'm going to say here.

Logan1x commented 7 years ago

@pradyunsg I sorry for the way you felt my intension's was not to hurt you in any sense. I want to conform and solve this problem asap and i didn't know the source you mentioned had wrriten for org. It's my first time as maintainer so this problem occured . Sorry for the experience you had

pradyunsg commented 7 years ago

Sorry for the experience you had

No issues. :)

It's my first time as maintainer

Text is a bad medium for conveying emotion. 🤷‍♂️

If you want to add @KayvanMazaheri (or whoever) as the assignee, they need to be a collaborator (i.e. able to push commits to this repository). If you're not comfortable with that, feel free to just mention that that person is going to tackle that issue in the OP -- the description of the issue.

You might want to give this a shot.

Logan1x commented 7 years ago

Next time surely because i already received PR and closing this issue now.

danishprakash commented 7 years ago

@Logan1x sorry, didn't read the description of the issue.

Logan1x commented 7 years ago

No Problem 😊 @prakashdanish