Sometimes votecount isn't posted with hammer

LoganMeitz / votefinder

GNU General Public License v3.0

2 stars 2 forks source link

Sometimes votecount isn't posted with hammer #22

Open rjmagley opened 1 year ago

rjmagley commented 1 year ago

Sometimes when Votefinder posts a hammer, it looks like this:

It should look like this, with the votecount appended:

Execute messages are handled by VoteCounter.post_execute_message(), which calls on an instance of VotecountFormatter to get the votes and present them as HTML or BBCode. I have a feeling it's choking on some edge case with the data it's getting and just outputting nothing.

rjmagley commented 1 year ago

I'm going to ask someone @ me on Discord when they notice this happen with a game so I can grab the data for the votes and see if I can't figure out what it's choking on.

rjmagley commented 1 year ago

After doing a significant rework of how Votefinder generates BBCode, I wonder if this might not be fixed - the only way to tell for sure will be when I can investigate more thoroughly

rjmagley commented 3 weeks ago

People are saying that since the last bits of code applied in 3.6 that this issue has stopped? I want to leave it open for a bit to see what happens but for now this may be good. My theory is that something was choking in generating BBCode to post during a hammer, and my fix for how I'm generating BBCode stopped that from happening.