search

Loghorn / ant-plus

A node module for ANT+
MIT License
138 stars 70 forks source link

multi-channel collision #33

Open casang opened 4 years ago

casang commented 4 years ago

Hi @Loghorn,

When I use Garmin Stick to connect to a Garmin Speed and Cadence Sensor, I am receiving "Unhandled Event" error regularly in ant.js file. I debugged the code and the problem is that the event EVENT_CHANNEL_COLLISION is not handled properly.

Collision is not an error on multi-channel networks, as devices uses only one antena.

So I just add the code below to handle EVENT_CHANNEL_COLLISION properly:

case Constants.EVENT_CHANNEL_COLLISION: return true; // collision is not an error on multi-channel networks

I really appreciate if you can merge these changes.

Find attached ANT AN15 specs: https://www.thisisant.com/assets/resources/Application%20Notes/ANT_AN15_Multi_Channel_Design_Considerations.pdf

AdrienFery commented 3 years ago

Hi @Loghorn,

Is there a particular reason why this PR is not merged? I have the same issue.

Thanks,

bierzorutas commented 3 years ago

+1