search

LogicAppUnit / TestingFramework

Unit testing framework for Azure Logic Apps (Standard)
MIT License
26 stars 13 forks source link

feat: Make Azurite IP Address configurable #22

Closed danielduartemindera closed 1 year ago

danielduartemindera commented 1 year ago

Making Azurite IP Address configurable, keeps retro compatibility and allow to run azurite in other ways

danielduartemindera commented 1 year ago

No longer needed.

mark-abrams commented 1 year ago

Hi @danielduartemindera , I can see that you have closed this PR. I was interested to know what the use case was that drove this change? Are you trying to run Azurite on a machine other than 127.0.0.1/localhost?

danielduartemindera commented 1 year ago

Hi Mark,

Actually, a wrong configuration on my machine was preventing the local up address 127.0.0.1 from working with azurite running on docker. I have cloned the repo and changed the ip to 0.0.0.0 and it worked. That's why it seems to me that it could be configurable. However, everything works fine now with the original code. Therefore, I think we don't need that change anymore.

Thanks for your framework. It helps a lot testing out azure logic apps with service bus actions.

I have also another PR that you might consider :)

Daniel Duarte

On Thu, Jul 6, 2023, 16:14 Mark Abrams @.***> wrote:

Hi @danielduartemindera https://github.com/danielduartemindera , I can see that you have closed this PR. I was interested to know what the use case was that drove this change? Are you trying to run Azurite on a machine other than 127.0.0.1/localhost?

— Reply to this email directly, view it on GitHub https://github.com/LogicAppUnit/TestingFramework/pull/22#issuecomment-1623859274, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCVVQXTIGVEZ44V63QUBTLXO3I4JANCNFSM6AAAAAA2ADBNR4 . You are receiving this because you were mentioned.Message ID: @.***>

mark-abrams commented 1 year ago

Thanks for that. I'm glad that you are finding the framework useful. If you have other suggestions or PRs to contribute, please feel free to fork the repo and create a PR with your change. I don't have much availability over the next few weeks but I'll certainly take a look at any PR.