search

LogicalError / realtime-CSG-for-unity

Realtime-CSG, CSG level editor for Unity
https://realtimecsg.com
MIT License
732 stars 76 forks source link

When dragging a material over a surface in the scene view, the undo stack is spammed with undo states #355

Closed nukeandbeans closed 1 year ago

nukeandbeans commented 2 years ago

Bug is located here: https://github.com/LogicalError/realtime-CSG-for-unity/blob/a3ccdb6d13be59bd7f9a31dfebfd7cd47d3f872c/Plugins/Editor/Scripts/View/DragAndDrop/SceneDragTool.Materials.cs#L564

Where the check is inverted from what it should be.

(!modified)
{
    // etc...
}

should be

(modified)
{
    // etc...
}

This will be fixed with other fixes in PR #349

Janooba commented 2 years ago

Confirmed fixed in #349 using 2019.4.31f1