LogicalError / realtime-CSG-for-unity

Realtime-CSG, CSG level editor for Unity
https://realtimecsg.com
MIT License
732 stars 76 forks source link

Package Structure Causes Conflicts #391

Open OwenMagelssen opened 8 months ago

OwenMagelssen commented 8 months ago

The structure of this package is causing errors with my project when installing via UPM because of the package's use of the 'Plugins' directory. It collides with use of the 'Plugins' folder in my project. The following error is produced in the editor console:

GUID [1c6e0549cfa34cb438dc26e26ec0d43c] for asset 'Packages/com.prenominal.realtimecsg/Plugins/Editor' conflicts with: 'Assets/Plugins/Editor' (current owner) We can't assign a new GUID because the asset is in an immutable folder. The asset will be ignored.

There doesn't appear to be a valid reason for using the special folder name 'Plugins' in this project. I'd recommend restructuring the package layout to more closely adhere to the conventions defined in the docs. If script compilation order was the reason for using 'Plugins', assembly definition files should be able resolve the issue.

nukeandbeans commented 8 months ago

The structure of the tool does not allow for moving it outside of the plugins folder. RealtimeCSG was never designed to be put in a package as it was designed initially for Unity 5.x and updated to more modern versions over time. Restructuring the project at this point would require a rewrite of a large portion of the code base, and creating an asmdef to separate editor from non-editor functionality breaks it entirely. If it is causing issues with your project, then you can simply move the tool to anywhere in the Assets folder instead. This is mentioned in the readme under the installation section. If you are using a version of Unity that is not LTS, then I will suggest doing so, as RealtimeCSG has not been thoroughly tested for non-LTS releases, and is very likely to break.