Logicify / mautic-advanced-templates-bundle

Plugin extends default email template capabilities with TWIG block so you can use advanced scripting techniques like conditions, loops etc
https://logicify.com/?utm_source=github&utm_campaign=mautic-templates&utm_medium=opensource
MIT License
86 stars 57 forks source link

Does it support email subjects? #2

Closed fullofcaffeine closed 2 years ago

fullofcaffeine commented 5 years ago

Hi!

I'm wondering if this supports email subjects. I need to output a different vowel in a word depending on the gender of the contact. In the body it was somewhat easy to solve with the dynamic content feature, but it's not supported for subjects in Mautic. Can I include TWIG conditionals in the email subject if I use your plugin?

Thanks!

corvis commented 5 years ago

Not at the moment unfortunately.

On Thu, Feb 14, 2019, 7:59 AM Marcelo Serpa <notifications@github.com wrote:

Hi!

I'm wondering if this supports email subjects. I need to output a different vowel in a word depending on the sex of the contact. In the body it was somewhat easy to solve with the dynamic content feature, but it's not supported for subjects in Mautic. Can I include TWIG conditionals in the email subject if I use your plugin?

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Logicify/mautic-advanced-templates-bundle/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AFVaD5LraerX103Q8bSfm-8ztpxD25Uyks5vNPs-gaJpZM4a646W .

fullofcaffeine commented 5 years ago

Thanks for the reply! Do you know of any workarounds for this scenario?

fullofcaffeine commented 5 years ago

Nevermind, I managed to extend your plugin to process subjects. I don't have time to push a PR now though but will do so over the next few days. Would you be willing to review/accept it?

corvis commented 5 years ago

Sure, it will be great.

On Fri, Feb 15, 2019, 1:12 AM Marcelo Serpa <notifications@github.com wrote:

Nevermind, I managed to extend your plugin to process subjects. I don't have time to push a PR now though but will do so over the next few days. Would you be willing to review/accept it?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Logicify/mautic-advanced-templates-bundle/issues/2#issuecomment-463840583, or mute the thread https://github.com/notifications/unsubscribe-auth/AFVaD-qOBQfVSiuM9Tv0PSMsJGy4thOsks5vNe1AgaJpZM4a646W .

virgilwashere commented 5 years ago

@fullofcaffeine any progress on the PR?

kuzmany commented 4 years ago

This PR could fixed it https://github.com/Logicify/mautic-advanced-templates-bundle/pull/10

fullofcaffeine commented 4 years ago

Sorry, I totally forgot about this issue. Are people still interested in this changeset?

PietkaSmig commented 4 years ago

Sorry, I totally forgot about this issue. Are people still interested in this changeset?

Yes we do :)

kfrankie commented 4 years ago

I would really like to test it.

corvis commented 4 years ago

PR which adds support for subjects has been accepted, please use release 1.1. Kudos to @kuzmany !

Could anyone confirm it works now?

bobsburgers commented 4 years ago

Seems Like it works to me.