search

LoginRadius / cascade

Create your internal developers' portal
MIT License
2 stars 13 forks source link

Added GitHub profile viewing #11

Open gridhead opened 3 years ago

gridhead commented 3 years ago

Uses GitHub public API with limited calls per unit time

Fixed #6.

Changes proposed in the pull request:

Risk Impact

@mohammed786

mohammed786 commented 3 years ago

Hey, thanks for contributing.

Can you please convert this HTML as React component so that the data can be fetched dynamically, If you are not good at React, you can create a separate issue that will be dependent on this issue for the same and ask if some want to work on the same.

gridhead commented 3 years ago

the data can be fetched dynamically,

Hi @mohammed786, the data is indeed fetched dynamically with the help of the GitHub public API, the code of which, I have included in the HTML document itself - so the only thing that you need to pass is the username to the function and all the preliminary details will be made available to you.

If you are not good at React, you can create a separate issue that will be dependent on this issue for the same and ask if some want to work on the same.

Yes. I might need some assistance in that. Here's hoping that the progress made here won't be disregarded and would be considered as the base for the conversion into a React component. :slightly_smiling_face:

Creating an issue now.

gridhead commented 3 years ago

Do check https://github.com/LoginRadius/cascade/issues/18. Also tagged a fellow contributor from my organization, should he be able to resolve the issue.

mohammed786 commented 3 years ago

Hi @t0xic0der , Thanks for contributing, since this HTML is already used in this PR, I am not merging this PR

gridhead commented 3 years ago

Understandable. Though indirectly, I'm glad to be able to contribute to a good project like this one. :sweat_smile: