search

LoginRadius / cascade

Create your internal developers' portal
MIT License
2 stars 13 forks source link

Responsive cascade #14

Closed chaitanya4vedi closed 3 years ago

chaitanya4vedi commented 3 years ago

Fixed #. While exploring the project i found a few bugs but that wasn't really related to the task so is left as it is. The App was almost fully responsive already. So no changes are made to the part that seem OK. Also the project made use of a framework sementic-ui and i used bootstrap to make it responsive and mobile friendly. So i carefully implemented only the requried part without letting it interfere with the sementic-ui implementation.

Changes proposed in the pull request:

Risk Impact

@mohammed786

mohammed786 commented 3 years ago

Hey @chaitanya4vedi , Thanks for contributing Can you please add the screenshot of the new ui so that i can have a look at it once.

chaitanya4vedi commented 3 years ago

Sure @mohammed786

LoginRadius_FullView LoginRadius_MobileView LoginRadius_MobileViewNav

mohammed786 commented 3 years ago

Hey Chaitanya, looks good. can you please take rebase for master and resolve the conflicts.

mohammed786 commented 3 years ago

LGTM thanks !