search

LoginRadius / egnature

Egnature is an email signature generator tool, which is an open source and free to use.
MIT License
35 stars 37 forks source link

on click "copy" will contains base64 copy of images, wide range of characters. #4

Open abhir9 opened 4 years ago

abhir9 commented 4 years ago

on click "copy" will contains base64 copy of images , which might be an issue with some email provider to not allow set as a signature (due to having more character then limit). try with gmail, go to setting to update signature it will block

rafaeelaudibert commented 4 years ago

@abhir9 What should be the behavior then? If you could clarify it, I could tackle this issue!

abhir9 commented 4 years ago

@rafaeelaudibert i am still not sure , what would the best way , still figuring this out , if you have any better idea , let me know

arc9693 commented 4 years ago

@abhir9

  1. We can use an HTML compressor that could compress the code before it is copied. Maybe use this.
  2. How about having an image server so that all the uploaded files could lie there. And then we don't need to have a base64 formatted image. Just the link to the image should be enough.

What are your thoughts on these ideas? I would like to work on this.

abhir9 commented 3 years ago

@arc9693 sorry for late reply, we don't want to maintain a additional image server, too keep the cost low and less dependent .

still if you want to contribute i can assign it you.

AmreshSinha commented 3 years ago

Instead of giving them a single result with image, we can give the client 2 results, one with base64 image (like for gmail) and one without any image (or a gravatar).

abhir9 commented 3 years ago

@AmreshSinha if user do not upload any image or profile picture it will be without image (gravtar) so finally it will be one only

AmreshSinha commented 3 years ago

@abhir9 If I don't upload any profile pic, then I am getting this: image

And its base64 image URL.

We can replace the default image with user's initials image with the help of UI-Avatars Service. https://ui-avatars.com/

Example: https://ui-avatars.com/api/?name=Amresh+Sinha&background=000&color=fff&rounded=true Example Avatar

AmreshSinha commented 3 years ago

So finally what can be the solution? 1) Uploading to Image server 2) or giving one more result pane without their profile image. (i.e. with UI avatars) (which bydefault should be there too) {This will be a proper image URL and not a base64 url)

What do you suggest @abhir9 ?

AmreshSinha commented 3 years ago

Bump (Sorry for the bump but I want to know what is the final resolution which is good for this issue) @abhir9