Closed raghunath-r-a closed 2 years ago
I suppose there are some inconsistency with the deployment command. Because the npm i command throws error.
@Pradumn-18 could you share a screenshot.
Yeah sure, I am attaching the log file of Netlify deployment build for better insights. The package installation is fine now. I figured that the package installation works fine with lower NodeJs version like 14.x, 12.x but gives error on 16.x. Now I face error in "npm run develop" command mentioned in README.md of the repository.
Please take a deep look into it.
Tried on Travis-CI Build is succeeding on Node v14.18.0 but failing on v16.10.0
This is the failing one: https://api.travis-ci.com/v3/job/540618696/log.txt
@raghunath-r-a @abhir9 you can assign me this issue. Just specify the final testing platform. I prefer going with Travis or as @Pradumn-18 said Netflify.
@AmreshSinha I guess Travis CI will not be preferable because their you would not be able to deploy the site. It will start executing the build but at last this is basically a site to be hosted, which will keep running in your build if it passes.I myself tried same on Github Action which is equivalent to Travis CI.
Moreover could you please share the logs of build that you claim is passing.
@AmreshSinha I guess Travis CI will not be preferable because their you would not be able to deploy the site. It will start executing the build but at last this is basically a site to be hosted, which will keep running in your build if it passes.I myself tried same on Github Action which is equivalent to Travis CI.
Moreover could you please share the logs of build that you claim is passing.
@Pradumn-18 Yeah it will be purely used for testing purposes and not for actual production build purpose.
and the fail error log: https://api.travis-ci.com/v3/job/540618696/log.txt
Ig the thing is with node version. It's working fine in node v14.x or node v12.x (as in Travis-CI)
@AmreshSinha Yes I agree to that, it fails with node version 16.x as I have also pointed out same in my prior comment.
@AmreshSinha @Pradumn-18 Thanks for highlighting this issue. This issue is due to an older version of Gatsby being used. We've created a new issue for the same: https://github.com/LoginRadius/engineering-portal/issues/789
Meanwhile, adding a status badge in README.md has been addressed by another pull request. (For your reference: https://github.com/LoginRadius/engineering-portal/pull/780)
CC: @abhir9 @mohammed786 @pareek-narendra
@Pradumn-18 Seems like gatsby version used in this portal is 2.x.x, which is not supported in node v16.x, kindly raise the PR in support to node version either v14.x
or v12.x
to run it locally till we upgrade the gatsby version for this portal.
For more details checkout this issue #789
Though the PR seems to have merged but unfortunately I am still not able to the badge for Netlify deployment.
Could you please look into that.
@mohammed786 Sure would do that.
Wish to work on that
@dontech09 Thanks for your interest in fixing this. But this has been already addressed by this pull request: https://github.com/LoginRadius/engineering-portal/pull/792
Please add the Deploy status badge in README.md
Status badges are visual representations of a site's status, served as image files that can be added to the site repository's READMEs, documentation, or any other web page. Please follow this URL