LoginRadius / go-saml

High Level API Implementation of SAML 2.0 (Currently Supported Identity Provider Implementation) Single Sign On
MIT License
12 stars 13 forks source link

Update schema.go #16

Closed sccalabr closed 3 years ago

sccalabr commented 3 years ago

Updated Schema for Organization and Contact. @mayankagwl I know I need to change the code for the information to be returned in the response. How would I got about testing this locally? I read the readme but I couldnt figure out how to get the examples to work. Do we have any unit tests?

All Submissions:

New Feature Submissions:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you lint your code locally prior to submission?

Changes to Core Features:

mayankagwl commented 3 years ago

@sccalabr there are some changes required, can you look it up. Thanks

sccalabr commented 3 years ago

Updated the pr. Let me know if this is what you were thinking.

mayankagwl commented 3 years ago

@sccalabr There are some issues with you PR, please look at them and test first

sccalabr commented 3 years ago

@sccalabr There are some issues with you PR, please look at them and test first

How do I test it locally? I looked in the contributing and the readme but didnt find steps on how to test.

mayankagwl commented 3 years ago

@sccalabr In Readme, there is mentioned how to install this go module go get github.com/LoginRadius/go-saml and there are also examples folder added in the repo, there are metadata example as well that show how to use it

mayankagwl commented 3 years ago

@sccalabr There are many issues in the PR, looks like you just copy-pasting the stuff to make it work. We can not accept this PR. So closing this pull request Thanks for your contribution