Add Github Action with linter - Githubissues

LoginRadius / go-saml

High Level API Implementation of SAML 2.0 (Currently Supported Identity Provider Implementation) Single Sign On

MIT License

12 stars 13 forks source link

Add Github Action with linter #18

Open x-way opened 3 years ago

x-way commented 3 years ago

Runs go vet, golint and staticcheck on the code. Also runs go test (a no-op as there are not tests yet).

Currently the linting fails with warnings about missing comments on exported methods. Good thing is there is aleady an issue (#4) to improve the comments :-)

An example of the output can be seen here: https://github.com/x-way/go-saml/actions/runs/285580397

Signed-off-by: Andreas Jaggi andreas.jaggi@waterwave.ch

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

[ ] Does your submission pass tests?
[ ] Have you lint your code locally prior to submission?

Changes to Core Features:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?