LoginRadius / lr-cli

lr is LoginRadius on the command line. You can perform basic actions of your LoginRadius Dashboard through command line. The actions includes login, register, logout, email configuration, domain whitelisting etc.
MIT License
11 stars 12 forks source link

Add support for opening auth page on jailbroken ios #50

Closed Torrekie closed 3 years ago

Torrekie commented 3 years ago

Checklist

Please note that in case of below checklist not updated accordingly, the maintainers have the right to immediately close your pull request.

Description of the Change

Added support for opening authentication webpage on jailbroken iOS devices.

There is a command uiopen to open URLs on iOS, users can get access to it after jailbreak.

Alternate Designs

Risk Impact

Verification Process

  1. Made changes to cmdutil/lrUtils.go
  2. Build with environment GOOS=ios (or build on iPhone natively), and run lr login, then it will call Safari up and open the authentication webpage
  3. Login with Google account, auth succeed, terminal outputs "Successfully Authenticated, Fetching Your Site(s)..."

Release Notes

mohammed786 commented 3 years ago

Hi @Torrekie, Thank you for showing interest in LoginRadius CLI, After going through your change I found that the change is specific to jailbroken ios, but hence LoginRadius is providing the authentication platform we will not able to include this case for security reasons. The normal ios case is handled and tested.

If you are interested in contributing more to LoginRadius CLI, kindly go through our Contributing Guildelines and also you can start the discussion on the LoginRadius Community Page.

Thanks!!! Mohammed Modi