search

LoginRadius / node-js-sdk

The LoginRadius Node JS library will let you integrate LoginRadius' customer identity platform with your Node JS application(s).
https://www.loginradius.com
MIT License
9 stars 21 forks source link

Dependencies should be devDependencies #24

Open dbrenot-pelmorex opened 1 year ago

dbrenot-pelmorex commented 1 year ago

When installing this package from npm, dependencies will be installed by anything that depends on this library. This means that eslint will be installed in my library and will stick around in production even though it's only needed when developing this library.

Please rename dependencies to devDependencies so that downstream users of this library don't have to install the dev dependencies and their transitive dependencies.

indrasen715 commented 1 year ago

Hi @dbrenot-pelmprex ,

Thanks for bringing this to our notice, and we appreciate your valuable feedback on this.

I will review this feedback with the team and keep you posted on the progress.

Regards Indrasen