LoicGrobol / zeldarose

Train transformer-based models.
https://zeldarose.readthedocs.io
Other
28 stars 3 forks source link

[Question] What is the proper accelerator since the update of Pytorch Lightning #32

Closed pjox closed 2 years ago

pjox commented 2 years ago

Since the update of Pytorch Lightning, ddp is no longer accepted as an accelerator (https://pytorch-lightning.readthedocs.io/en/stable/api/pytorch_lightning.accelerators.Accelerator.html). So when before I was using:

--accelerator ddp \
--n-gpus 4 \
--n-workers 4 \

I'm now using

--accelerator gpu \
--strategy ddp \
--num-devices 4 \
--num-workers 4 \
--num-nodes 128 \

Is this correct?

Thanks in advance for the help 😄

LoicGrobol commented 2 years ago

Yes, that's correct, fixing it in the readme now!