Lokathor / bytemuck

A crate for mucking around with piles of bytes
https://docs.rs/bytemuck
Apache License 2.0
697 stars 77 forks source link

Bytemuck 1.14.2 does not build on stable #226

Closed IceTDrinker closed 7 months ago

IceTDrinker commented 7 months ago

Following the nightly stdsimd/stdarch change the latest patch breaks the builds on stable

e.g.

error[E0658]: use of unstable library feature 'stdsimd'
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bytemuck-1.14.2/src/lib.rs:122:28
    |
122 |       unsafe impl $trait for $platform::$first_type {}
    |                              ^
    |
   ::: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bytemuck-1.14.2/src/zeroable.rs:239:1
    |
239 | / impl_unsafe_marker_for_simd!(
240 | |   #[cfg(all(target_arch = "x86_64", feature = "nightly_stdsimd"))]
241 | |   unsafe impl Zeroable for x86_64::{
242 | |     __m128bh, __m256bh, __m512,
243 | |     __m512bh, __m512d, __m512i,
244 | |   }
2[45](https://github.com/zama-ai/tfhe-rs/actions/runs/7816649010/job/21322692304?pr=865#step:6:46) | | );
    | |_- in this macro invocation
    |
    = note: see issue #48556 <https://github.com/rust-lang/rust/issues/48556> for more information
    = help: add `#![feature(stdsimd)]` to the crate attributes to enable
    = note: this error originates in the macro `impl_unsafe_marker_for_simd` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0658]: use of unstable library feature 'stdsimd'
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bytemuck-1.14.2/src/lib.rs:122:28
    |
122 |       unsafe impl $trait for $platform::$first_type {}
    |                              ^
    |
   ::: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bytemuck-1.14.2/src/pod.rs:159:1
    |
159 | / impl_unsafe_marker_for_simd!(
160 | |   #[cfg(all(target_arch = "x86_64", feature = "nightly_stdsimd"))]
161 | |   unsafe impl Pod for x86_64::{
162 | |     __m128bh, __m256bh, __m512,
163 | |     __m512bh, __m512d, __m512i,
164 | |   }
165 | | );
    | |_- in this macro invocation
    |
    = note: see issue #[48](https://github.com/zama-ai/tfhe-rs/actions/runs/7816649010/job/21322692304?pr=865#step:6:49)556 <https://github.com/rust-lang/rust/issues/48556> for more information
    = help: add `#![feature(stdsimd)]` to the crate attributes to enable
    = note: this error originates in the macro `impl_unsafe_marker_for_simd` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0635]: unknown feature `stdarch_x86_avx512`
 --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bytemuck-1.14.2/src/lib.rs:7:50
  |
7 | #![cfg_attr(feature = "nightly_stdsimd", feature(stdarch_x86_avx512))]
  |                                                  ^^^^^^^^^^^^^^^^^^

Some errors have detailed explanations: E0635, E06[58](https://github.com/zama-ai/tfhe-rs/actions/runs/7816649010/job/21322692304?pr=865#step:6:59).
For more information about an error, try `rustc --explain E0635`.
error: could not compile `bytemuck` (lib) due to 7 previous errors
warning: build failed, waiting for other jobs to finish...
make: *** [Makefile:2[62](https://github.com/zama-ai/tfhe-rs/actions/runs/7816649010/job/21322692304?pr=865#step:6:63): build_core] Error 101
Error: Process completed with exit code 2.
IceTDrinker commented 7 months ago

sorry about, misconfiguration of the build on our end