search

Lokathor / bytemuck

A crate for mucking around with piles of bytes
https://docs.rs/bytemuck
Apache License 2.0
697 stars 77 forks source link

Address `unexpected_cfgs` warnings instead of allowing the lint #243

Closed Urgau closed 3 months ago

Urgau commented 3 months ago

r? @Lokathor

Lokathor commented 3 months ago

so does this deny the spirv check?

or does it allow the check which is expected to be deny by default?

Urgau commented 3 months ago

It denies the lint (aka #![deny(unexpected_cfgs)]) and expect/allow the target_arch = "spirv" cfg (so it can be used without triggering the lint).

Lokathor commented 3 months ago

...okay.

Not very good key names, but it's already on the way to stable so i guess I'll just ignore yet another part of rust

Urgau commented 3 months ago

Not very good key names, but it's already on the way to stable so i guess I'll just ignore yet another part of rust

check-cfg matches rustc --check-cfg flag

Lokathor commented 3 months ago

I guess I'm just not familiar with that area. To the uninitiated it doesn't read well.

Urgau commented 3 months ago

If your interested in knowing more, here is the Cargo specific doc and here the rustc --check-cfg doc.

The output of the lint links directly to the Cargo specific doc.

To the uninitiated it doesn't read well.

If you have ideas on how to improve the situation I'm happy to here them.

Lokathor commented 3 months ago

Well like I said by now it's already stable in rustc the next release, and in cargo the release after that. I don't think anyone would seriously entertain any changes at this point.