Implement multiplication in most vectors that dont have it

Lokathor / wide

A crate to help you go wide. By which I mean use SIMD stuff.

https://docs.rs/wide

zlib License

279 stars 23 forks source link

Implement multiplication in most vectors that dont have it #103

Closed ImUrX closed 3 years ago

ImUrX commented 3 years ago

Here we are, I implemented

Multiplication for i64x2, i64x4, u64x2, u64x4 u32x4 u16x8
Splats for all of them so you can simply do i64x2 * i64
Tests for all the types

i think we should implement multiplication in every type that can have it, better done now than later tbh

fixes #102

ImUrX commented 3 years ago

should i continue in implementing Mul to other vectors? (+ splat)

Lokathor commented 3 years ago

That would be great.

Also, if you can impl Mul<simd> for scalar so that the scalar value can be on the left side of the * that would be handy. I think f32x4 has this sort of thing as an example.

ImUrX commented 3 years ago

will implement tests later

ImUrX commented 3 years ago

rustfmt returned Warning: the `merge_imports` option is deprecated. Use `imports_granularity=Crate` instead

Lokathor commented 3 years ago

Ah, yeah, the file is a little old but i usually have format-on-save set in VS Code so I forget the warning. I'll get it at some point.

ImUrX commented 3 years ago

Well it's done, and it doesnt seem like a breaking change :P

ImUrX commented 3 years ago

@Lokathor i dont have write access if you are waiting for that

Lokathor commented 3 years ago

Just wasn't sure if you were gonna add more :3

ImUrX commented 3 years ago

im gonna check some of the other issues later, but for now, im gonna end what i started in the project i was working on

Lokathor / wide

Implement multiplication in most vectors that dont have it #103

Tests for all the types