Lokathor / wide

A crate to help you go wide. By which I mean use SIMD stuff.
https://docs.rs/wide
zlib License
279 stars 23 forks source link

u32x8 compare methods implemented as functions and not as traits #85

Open RazrFalcon opened 3 years ago

Lokathor commented 3 years ago

say what now?

RazrFalcon commented 3 years ago

https://github.com/Lokathor/wide/blob/cb91288ded8f2c2101cd23f2a64bede67240f4e3/src/u32x8_.rs#L254

https://github.com/Lokathor/wide/blob/cb91288ded8f2c2101cd23f2a64bede67240f4e3/src/u32x4_.rs#L177

Lokathor commented 3 years ago

Oh. but it looks like those methods also exist in the latest of the main branch? And in the published 0.6.4 version.

Where are you not seeing them available?

RazrFalcon commented 3 years ago

Yes, they exist. But in f32x8 they are implemented as traits, not as methods.

Lokathor commented 3 years ago

Oh, that, yeah. If you want to have the trait option just make a PR for trait impls that call the method. We can get that published real quick.

RazrFalcon commented 3 years ago

No, I don't actually use them. Just noticed this issue while was reading the code. It can be fixed at any time.