new: import an existing wallet from the Dashboard

[github-actions[bot]]

✔️ translation is up-to-date

:x: code style needs update

It seems your code wasn't properly formatted using our current rules.

Please run src/App.vue 458ms src/assets/custom-variables.scss 42ms src/assets/datepicker.scss 3ms src/assets/fonts/roboto/style.css 27ms src/assets/main.scss 48ms src/assets/native.scss 4ms src/assets/switch-prefs.scss 10ms src/components/AboutModal.vue 80ms src/components/AuthChallenge.vue 54ms src/components/AuthChallengeDirect.vue 34ms src/components/AuthChallengePin.vue 39ms src/components/AuthChallengeRetention.vue 31ms src/components/AuthPref.vue 90ms src/components/AuthPrefDirect.vue 7ms src/components/AuthPrefPin.vue 67ms src/components/AuthPrefRetention.vue 12ms src/components/AuthPrefs.vue 34ms src/components/BankAccountItem.vue 61ms src/components/BiometryPrefs.vue 38ms src/components/ConfirmPaymentModal.vue 102ms src/components/CreateAccount.vue 116ms src/components/Dialog.vue 26ms src/components/LangPrefs.vue 35ms src/components/Modal.vue 17ms src/components/MoneyCreditModal.vue 71ms src/components/MoneyTransferModal.vue 161ms src/components/PendingTopUp.vue 41ms src/components/QrCodeModal.vue 34ms src/components/RecipientItem.vue 18ms src/components/ScanQrCode.vue 15ms src/components/TheBankAccountList.vue 116ms src/components/TheDashboardFooter.vue 38ms src/components/TheNavBar.vue 97ms src/components/TheTransactionList.vue 23ms src/components/TransactionItem.vue 23ms src/components/TransactionListModal.vue 213ms src/components/TransactionListRecent.vue 49ms src/exception.ts 12ms src/main.ts 64ms src/plugins/loading.ts 8ms src/plugins/vue-loading-overlay.d.ts 3ms src/polyfill.ts 5ms src/router/index.ts 16ms src/services/AuthService.ts 38ms src/services/Biometry.ts 12ms src/services/DatePicker.ts 14ms src/services/Dialog.ts 3ms src/services/ExportService.ts 11ms src/services/Gettext.ts 16ms src/services/lokapiService.ts 30ms src/services/PrefsService.ts 7ms src/services/QrCodeService.ts 13ms src/services/secret.ts 13ms src/services/toastService.ts 6ms src/services/UseBatchLoading.ts 10ms src/services/UseModal.ts 19ms src/shims-vue.d.ts 3ms src/store/index.ts 18ms src/store/lokapi.ts 34ms src/store/prefs.ts 3ms src/utils/fonts.ts 3ms src/utils/password.ts 3ms src/utils/vuex.ts 3ms src/views/admin/PendingAccounts.vue 56ms src/views/admin/PendingCredits.vue 74ms src/views/Carto.vue 9ms src/views/CreateMyAccount.vue 5ms src/views/Dashboard.vue 27ms src/views/Login.vue 60ms src/views/Prefs.vue 19ms src/views/ResetPassword.vue 42ms src/views/Signup.vue 103ms on your code before submitting the PR. You can amend this current PR.

18 files changed, 21 insertions(+), 61 deletions(-)

```diff diff --git a/src/App.vue b/src/App.vue index 56d1d38..8f8fb36 100644 --- a/src/App.vue +++ b/src/App.vue @@ -23,7 +23,6 @@ await StatusBar.setStyle({ style: Style.Light }) } CapacitorApp.addListener("backButton", ({ canGoBack }) => { - // XXXvlab: will need a back button service to insert these if (this.$qrCode.isActive()) return if (this.$modal.isActive.value) { this.$modal.back() diff --git a/src/components/AuthChallenge.vue b/src/components/AuthChallenge.vue index 38a8343..5557b3a 100644 --- a/src/components/AuthChallenge.vue +++ b/src/components/AuthChallenge.vue @@ -73,7 +73,6 @@ hide() { this.visible = false - // Destroys in memory previous challenge structure this.handler = false }, diff --git a/src/components/AuthChallengeRetention.vue b/src/components/AuthChallengeRetention.vue index 55b2f99..a8aecc5 100644 --- a/src/components/AuthChallengeRetention.vue +++ b/src/components/AuthChallengeRetention.vue @@ -36,14 +36,12 @@ }, async mounted() { this.subState = this.state - // Do we have some credential saved in store ? if (await this.handler.checkUserInput()) { if (this.state === "firstTry") { const lastCredsInput = await this.handler.inferKey() this.submitInput(lastCredsInput) return } - // Uh-oh, these weren't valid credentials this.handler.constructor.flush() this.subState = "firstTry" } diff --git a/src/components/AuthPref.vue b/src/components/AuthPref.vue index ac871de..f573313 100644 --- a/src/components/AuthPref.vue +++ b/src/components/AuthPref.vue @@ -102,13 +102,8 @@ } return true }, - /** - * Trigger direct default challenge an disable any retention - */ triggerDefaultChallenge() { return this.triggerChallenge(async (state: any, userAccount: any) => { - // By not asking the specific userAccount's auth, we remove - // any retention mecanism aspect. const accountAuthService = await this.$auth.getAccountAuth() return await accountAuthService.requestCredentials(state) }) @@ -128,7 +123,6 @@ setUseSimplifiedAuth(value: any) { this.useSimplifiedAuth = value this.$refs.checkbox.checked = value - // XXXvlab: nextTick didn't work. setTimeout(() => { this.$refs.checkbox.checked = value }, 0) @@ -136,12 +130,7 @@ async switchSimplifiedAuth(e: any) { e.preventDefault() if (this.useSimplifiedAuth) { - // Was on, switching off if (!(await this.triggerDefaultChallenge())) { - // XXXvlab: vuejs won't see any changes so won't force - // the checkbox to be unchecked. But it is automatically checked - // despite the preventDefault. - // this.useSimplifiedAuth = true this.setUseSimplifiedAuth(true) return } @@ -152,12 +141,7 @@ this.$forceUpdate() return } - // ``useSimplifiedAuth`` was off, switching on if (!(await this.triggerDefaultChallenge())) { - // XXXvlab: vuejs won't see any changes so won't force - // the checkbox to be unchecked. But it is automatically checked - // despite the preventDefault. - // this.useSimplifiedAuth = false this.setUseSimplifiedAuth(false) return } diff --git a/src/components/AuthPrefs.vue b/src/components/AuthPrefs.vue index fd7a48d..0659350 100644 --- a/src/components/AuthPrefs.vue +++ b/src/components/AuthPrefs.vue @@ -38,9 +38,6 @@ const $auth = this.$auth const moreThanOneUserAccount = userAccounts.length !== 1 - // XXXvlab: typeforcing to 'any' as typescript doesn't seem to - // understand that a 'allSettled' is actually a Promise of an - // array. const preparedTemplateDataPromises = (await Promise.allSettled( userAccounts.map(async (userAccount: any) => ({ name: diff --git a/src/components/BiometryPrefs.vue b/src/components/BiometryPrefs.vue index 730ae43..e5ab210 100644 --- a/src/components/BiometryPrefs.vue +++ b/src/components/BiometryPrefs.vue @@ -62,7 +62,6 @@ setUseBiometry(value: any) { this.setUserBiometry(value) this.useBiometry = value - // XXXvlab: nextTick didn't work. setTimeout(() => { this.$refs.biometryCheckbox.checked = value }, 0) diff --git a/src/components/ConfirmPaymentModal.vue b/src/components/ConfirmPaymentModal.vue index f88c095..680d5cc 100644 --- a/src/components/ConfirmPaymentModal.vue +++ b/src/components/ConfirmPaymentModal.vue @@ -181,8 +181,6 @@ }, methods: { async payTopUpRequest(): Promise { - // XXXvlab: we would need to launch regular checks - // here to acknowledge the payment window.open( this.$modal.args?.value[0].transaction.jsonData.odoo.order_url, "_blank" @@ -199,7 +197,6 @@ paymentStatus = await this.promiseWaitPayment } catch (err) { if (err === false) { - // The current modal was closed while waiting return } throw new UIError( @@ -211,13 +208,11 @@ } let modalName = this.$modal.modal.value if (modalName !== "ConfirmPaymentModal") { - // The modal was likely closed while waiting return } let myCurrentOrderId = this.$modal.args?.value[0].transaction.jsonData.odoo.order_id if (myCurrentOrderId !== orderId) { - // The modal was likely closed while waiting return } this.closeAndRefresh() @@ -232,7 +227,6 @@ let modalArgs = this.$modal.args?.value let modalName = this.$modal.modal.value if (modalName !== "ConfirmPaymentModal") { - // The modal was likely closed while waiting clearInterval(interval) reject(false) return @@ -240,7 +234,6 @@ let myCurrentOrderId = this.$modal.args?.value[0].transaction.jsonData.odoo.order_id if (myCurrentOrderId !== orderId) { - // The modal was likely closed while waiting clearInterval(interval) reject(false) return diff --git a/src/components/CreateAccount.vue b/src/components/CreateAccount.vue index 28910d6..34fe618 100644 --- a/src/components/CreateAccount.vue +++ b/src/components/CreateAccount.vue @@ -279,7 +279,7 @@ this.$gettext("Please try again or contact your administrator") ) - return // stay on page + return } this.$msg.warning(this.$gettext("Wallet already created")) } diff --git a/src/components/LangPrefs.vue b/src/components/LangPrefs.vue index 17a7b16..0e7cb3c 100644 --- a/src/components/LangPrefs.vue +++ b/src/components/LangPrefs.vue @@ -65,7 +65,6 @@ setUseCustomLanguage(value: any) { this.setCustomLanguage(value ? this.userLanguage : null) this.useCustomLanguage = value - // XXXvlab: nextTick didn't work. setTimeout(() => { this.$refs.langCheckbox.checked = value }, 0) diff --git a/src/components/MoneyCreditModal.vue b/src/components/MoneyCreditModal.vue index 786fb15..1dbd4a6 100644 --- a/src/components/MoneyCreditModal.vue +++ b/src/components/MoneyCreditModal.vue @@ -170,7 +170,6 @@ : false }, async newLinkTab() { - // This to ensure we are left with 2 decimals only this.amount = this.amount.toFixed(2) const { refreshTransaction, account } = this.$modal.args.value[0] diff --git a/src/components/MoneyTransferModal.vue b/src/components/MoneyTransferModal.vue index 5ddbe83..35a6ca9 100644 --- a/src/components/MoneyTransferModal.vue +++ b/src/components/MoneyTransferModal.vue @@ -261,7 +261,6 @@ account = account._obj.parent } this.account = account - // No need to declare in data, no live mechanism required here this.selectedBackend = account.parent this.recipientBatchLoader = UseBatchLoading({ @@ -374,7 +373,6 @@ this.transferOngoing = false return } - // This to ensure we are left with 2 decimals only this.amount = parseFloat(this.amount).toFixed(2) let dateBegin = Date.now() let payment @@ -400,7 +398,6 @@ return } if (err.message === "User canceled the dialog box") { - // A warning message should have already been sent return } this.$msg.error( @@ -449,8 +446,6 @@ try { await this.selectedRecipient.toggleFavorite() } catch (err) { - // XXXvlab: using ``.then`` makes it trigger outside of - // view js grasp. this.$errorHandler(err) return } diff --git a/src/components/QrCodeModal.vue b/src/components/QrCodeModal.vue index 63e043a..f032b6b 100644 --- a/src/components/QrCodeModal.vue +++ b/src/components/QrCodeModal.vue @@ -71,8 +71,8 @@ methods: { async downloadQrCodePdf() { let svgQrCode = this.$refs.qrCode.firstChild.outerHTML - const finalSizeMm = 120 // mm of final printed QrCode - const resolution = 5 // px/mm + const finalSizeMm = 120 + const resolution = 5 svgQrCode = svgQrCode.replace( 'width="200"', @@ -94,7 +94,6 @@ const imgData = canvas.toDataURL("image/png") - // Generate PDF let pdf = new jsPDF("p", "mm", "a4") await pdf.addImage( diff --git a/src/components/TheBankAccountList.vue b/src/components/TheBankAccountList.vue index 40a4f01..97fb2e0 100644 --- a/src/components/TheBankAccountList.vue +++ b/src/components/TheBankAccountList.vue @@ -42,10 +42,10 @@

[github-actions[bot]]

:evergreen_tree: test report

Passes: 20, failures: 0, pending: 0, skipped: 0, other: 0.

[vaab]

Live reviewed, corrected, tested locally, pushed.