chg: hide top-up button on dashboard's footer dependng on the ``topUp…

SeddikKadi commented 3 months ago

…`` variable in config.json

github-actions[bot] commented 2 months ago

✔️ translation is up-to-date

✔️ code style matches our guidelines

:page_with_curl: Metrics report

Bundle size analysis

```diff -129094 js/50.8446c537.js +129094 js/50.25e59abd.js -175702 js/app.1fe40d26.js -1983281 js/chunk-vendors.984b1953.js -242886 css/app.64ca62ec.css +175770 js/app.70969ad1.js +1983281 js/chunk-vendors.7a89b231.js +242886 css/app.b3f236df.css ```

Eslint analysis

```diff -/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:386:13: 'dateBegin' is never reassigned. Use 'const' instead. [Error/prefer-const] -/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:386:13: 'dateBegin' is assigned a value but never used. [Error/@typescript-eslint/no-unused-vars] -/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:394:23: Unexpected any. Specify a different type. [Error/@typescript-eslint/no-explicit-any] -/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:445:11: Unexpected console statement. [Warning/no-console] -/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:473:34: Unexpected any. Specify a different type. [Error/@typescript-eslint/no-explicit-any] -/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:493:38: 'reject' is defined but never used. [Error/@typescript-eslint/no-unused-vars] +/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:391:13: 'dateBegin' is never reassigned. Use 'const' instead. [Error/prefer-const] +/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:391:13: 'dateBegin' is assigned a value but never used. [Error/@typescript-eslint/no-unused-vars] +/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:399:23: Unexpected any. Specify a different type. [Error/@typescript-eslint/no-explicit-any] +/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:450:11: Unexpected console statement. [Warning/no-console] +/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:478:34: Unexpected any. Specify a different type. [Error/@typescript-eslint/no-explicit-any] +/home/runner/work/monujo/monujo/src/components/MoneyTransferModal.vue:498:38: 'reject' is defined but never used. [Error/@typescript-eslint/no-unused-vars] ```

github-actions[bot] commented 2 months ago

:evergreen_tree: test report

Passes: 4, failures: 14, pending: 0, skipped: 2, other: 0.

| State | Description | | ------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: Login and logout process start page show base interface and login form
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `button`, but never found it. Queried from: > cy.get(.links-container) | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: Login and logout process login with correct credentials succeeds, logout
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `.action-footer:visible`, but never found it. | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: General processes when logged in show base interface
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `.accounts`, but never found it. | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: General processes when logged in Send money process
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `.accounts`, but never found it. | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: General processes when logged in Top-up process
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `.accounts`, but never found it. | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: Preferences page show base interface
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `.action-footer:visible`, but never found it. | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: Signup process Signup page show form
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `button`, but never found it. Queried from: > cy.get(.links-container) Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `Signup process` | | skipped | **Filepath**: tests/e2e/spec.cy.ts
**Title**: Signup process Signup with already existing email
**Error**: null | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: Login and logout process start page show base interface and login form
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `button`, but never found it. Queried from: > cy.get(.links-container) | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: Login and logout process login with correct credentials succeeds, logout
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `.action-footer:visible`, but never found it. | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: General processes when logged in show base interface
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `.accounts`, but never found it. | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: General processes when logged in Send money process
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `.accounts`, but never found it. | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: General processes when logged in Top-up process
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `.accounts`, but never found it. | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: Preferences page show base interface
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `.action-footer:visible`, but never found it. | | fail | **Filepath**: tests/e2e/spec.cy.ts
**Title**: Signup process Signup page show form
**Error**: AssertionError: Timed out retrying after 60000ms: Expected to find element: `button`, but never found it. Queried from: > cy.get(.links-container) Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `Signup process` | | skipped | **Filepath**: tests/e2e/spec.cy.ts
**Title**: Signup process Signup with already existing email
**Error**: null |

vaab commented 1 month ago

Live reviewed, a few small adjustement, pushed

Lokavaluto / monujo