search

Loki-Afro / metalarchives

Unofficial Encyclopedia Metallum API
Other
44 stars 12 forks source link

No line-up #20

Closed Czral closed 1 year ago

Czral commented 1 year ago

Hello there,

When I try to fetch the line-up for a band (Current line-up, Last known line-up, Past line-up or Live line-up) I don't get any results (Size is 0). I tried even well known bands such as Metallica or Iron Maiden. At the same time I get the line-up for albums perfectly fine. Is there something wrong with my get method (I'm using band.getPastLineup(), band.getCurrentLineup(), band.getLiveLineup(), band.getLastKnownLineup() methods) or is generally not available?

Thank you for your time!

Loki-Afro commented 1 year ago

@Czral sorry for getting so late to you, the whole band member situation is rather rough since i never actually needed it :D

can you give me some kind of unit-test like code snippet to hang along? although i'm already guessing the lineup thing is pretty much a global issue

Loki-Afro commented 1 year ago

yeah .. had a quick look, there is not a single test thats doing anyting with lineup, and this crappy html "parsing" broke here

com.github.loki.afro.metallum.core.parser.site.helper.band.MemberParser#parse which should be rewritten entirely i think using jsoup as the rest of the code does

Loki-Afro commented 1 year ago

@Czral is that something you are looking for? https://github.com/Loki-Afro/metalarchives/pull/21/files#diff-ce32dbb21a79913baf0287a5eaf6d57a366b96056e6c2a5e14a846b12c167209R660 are you missing some information here?

what would be not parsed is "ex-" and "R.I.P." infos