Loki-Astari / JsonBenchmark

Json benchmark based on nativejson-benchmark
Other
25 stars 6 forks source link

Modified the Jsonifier commit. #27

Closed RealTimeChris closed 1 month ago

RealTimeChris commented 1 month ago

I noticed that in your most recent commit you reverted the Jsonifier commit - which has resulted in many more conformance failures than what it currently produces. Can you please merge this into it so that is no longer the case?

Loki-Astari commented 1 month ago

You do realize you don't have to remove then add submodules to update them!

1: Make sure they are locaded locally. 2: Update them to the correct version (preferably main/master but I know you like dev on Jasonifer). 3: Add then commit.

> git clone git@github.com:Loki-Astari/JsonBenchmark.git
> cd JsonBenchmark
> git submodule update --init --recursive
> cd thirdparty/Jsonifier/
> # optional pull if you have done something recently in another repo
> # git  pull
> git checkout dev
> cd ../..
> git add thirdparty/Jsonifier
> git commit -m "Update Jsonifier to latest version"
> git push
Loki-Astari commented 1 month ago

Submodule Jsonifier added at 58e1ce Is not the latest build nor is it tagged with a special version.

Loki-Astari commented 1 month ago

Seems like this is one commit behind dev. Is there a reason this is not master?

Loki-Astari commented 1 month ago

Submodule glaze added at 76fbda

This is main so no problem. Will update that.

Loki-Astari commented 1 month ago

Submodule simdjson added at 3ef307

This is already the version being used. No change.

Loki-Astari commented 1 month ago

Update Glaze and Jsonifier to versions requested. Closing this pull request as it is complete.