Closed RealTimeChris closed 1 month ago
You do realize you don't have to remove then add submodules to update them!
1: Make sure they are locaded locally. 2: Update them to the correct version (preferably main/master but I know you like dev on Jasonifer). 3: Add then commit.
> git clone git@github.com:Loki-Astari/JsonBenchmark.git
> cd JsonBenchmark
> git submodule update --init --recursive
> cd thirdparty/Jsonifier/
> # optional pull if you have done something recently in another repo
> # git pull
> git checkout dev
> cd ../..
> git add thirdparty/Jsonifier
> git commit -m "Update Jsonifier to latest version"
> git push
Seems like this is one commit behind dev. Is there a reason this is not master?
Update Glaze and Jsonifier to versions requested. Closing this pull request as it is complete.
I noticed that in your most recent commit you reverted the Jsonifier commit - which has resulted in many more conformance failures than what it currently produces. Can you please merge this into it so that is no longer the case?