search

Lokicoule / nestjs-cognito

AWS Cognito utilities module for NestJS.
https://www.npmjs.com/package/@nestjs-cognito/auth
MIT License
74 stars 7 forks source link

`jwksCache` option to avoid a time out error #515

Closed ikeda1729 closed 1 year ago

ikeda1729 commented 1 year ago

I encountered a cognito timeout error describe in: https://github.com/awslabs/aws-jwt-verify/issues/72#issuecomment-1139609992

To avoid this error, jwksCache option is necessary. To fix this, the code in cognito.utils.js should be like this: const { userPoolId, clientId, tokenUse = "id", additionalProperties, ...others } = cognitoModuleOptions.jwtVerifier;

Should I make the PR for this?

Lokicoule commented 1 year ago

Hello @ikeda1729,

Thank you for bringing this issue to my attention and for offering to create a PR. I appreciate your willingness to contribute to the project, please feel free to create a PR next time!

However, I have already made the necessary changes following your recommandations and published a new version (v1.1.0) of the @nestjs-cognito/core module. I hope this resolves the issue you were experiencing. (Don't forget to update @nestjs-cognito/auth to 1.0.5)

Thank you again Yusuke for your help in improving this project.

ikeda1729 commented 1 year ago

Thank you for your reply, @Lokicoule.

Oh, you already fixed this issue. I will update my project.

Thank you.