search

Lokrates / Biofuel

A Minetest-Mod to produce biofuel from unused plants.
Other
5 stars 9 forks source link

Adds support for Vines mod #7

Closed 6r1d closed 4 years ago

6r1d commented 4 years ago

Hello. I think it's worth to add the support for vines mod by @bas080. PR is tested locally, those vines work. Thanks!

OgelGames commented 4 years ago

The vines don't need to be added to both the biomass.convertible_groups and biomass.convertible_nodes, just adding the group will cover them all.

6r1d commented 4 years ago

The vines don't need to be added to both the biomass.convertible_groups and biomass.convertible_nodes, just adding the group will cover them all.

Are you sure this is the case? If I remember correctly, adding a group only wasn't enough in tests yesterday.

OgelGames commented 4 years ago

Are you sure this is the case?

Yes, groups tree and leaves work, don't they? :wink:

6r1d commented 4 years ago

Yes, groups tree and leaves work, don't they?

Yes. I did a test and removed all vines from biomass.convertible_nodes. There is a currently unused node, vines:vines, which might become some kind of rope and it was not processed by the refinery, so I am leaving it for now. It is outside the vines group, which initially motivated me to add all possible vines there.

BuckarooBanzay commented 4 years ago

@Lokrates ^