Lolcoincoin / tekkub-wow

Automatically exported from code.google.com/p/tekkub-wow
0 stars 0 forks source link

Tour guide quest tracker problem with LightHeaded #560

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Open a guide
2. Click on a quest in the tracker that you do not currently have in the quest 
log
3. The quest log opens, but does not show what we want to see

What is the expected output? What do you see instead?
As with quests I currently have, the quest details are shown and the 
LightHeaded frame shows the opened quest. But with quests that are currently 
not in my log, the frame opens, but the LightHeaded 
comments are of a quest I do have, not the one I clicked in the tracker.

What version of the addon are you using?  Where did you download from?
 2.4.2.30 from http://tekkub-wow.googlecode.com/files/TourGuide-2.4.2.30.zip

What version of WoW are you using?
Patch: 2.4.3
Locale: en

Please provide any additional information below.
To say again, the problem is quests not in my log that I click on the tracker 
to open the quest frame do 
not show the LightHeaded comments for the quest I want. Tekkub, I see many of 
your guides have the 
quest ID in them. Would there be some way of opening the page of LightHeaded 
with that as the index?

Original issue reported on code.google.com by MikeNGoS...@gmail.com on 21 Sep 2008 at 4:38

GoogleCodeExporter commented 9 years ago
LH would have to provide some sort of API to do this, but there's really no 
point to 
it, unless I'm missing something.

Original comment by Tekkub on 21 Sep 2008 at 5:24

GoogleCodeExporter commented 9 years ago
I think I found the call we are looking for:

LightHeaded:UpdateFrame(qid, page)

Original comment by MikeNGoS...@gmail.com on 21 Sep 2008 at 6:31

GoogleCodeExporter commented 9 years ago
Tekkub, I added the following code in StatusFrame.lua: 
LightHeaded:UpdateFrame(TourGuide:GetObjectiveTag("QID", nextstep), 1)
It now fixes Issue 560.

--------------
function dataobj.OnClick(self, btn)
    if TourGuide.db.char.currentguide == "No Guide" then InterfaceOptionsFrame_OpenToFrame(TourGuide.guidespanel)
    else
        if btn == "RightButton" then
            if TourGuide.objectiveframe:IsVisible() then
                HideUIPanel(TourGuide.objectiveframe)
            else
                local quad, vhalf, hhalf = GetQuadrant(self)
                local anchpoint = (vhalf == "TOP" and "BOTTOM" or "TOP")..hhalf
                TourGuide.objectiveframe:ClearAllPoints()
                TourGuide.objectiveframe:SetPoint(quad, self, anchpoint)
                ShowUIPanel(TourGuide.objectiveframe)
            end
        else
            local i = TourGuide:GetQuestLogIndexByName()
            if i then SelectQuestLogEntry(i) end
            ShowUIPanel(QuestLogFrame)
            if LightHeaded then LightHeaded:UpdateFrame(TourGuide:GetObjectiveTag("QID", nextstep), 1) end --Added to fix a bug where one could not open the quest 
details with LightHeaded, with nil check so it will not throw an error if 
LightHeaded is not loaded
        end
    end
end
----------------

Original comment by MikeNGoS...@gmail.com on 21 Sep 2008 at 5:31

GoogleCodeExporter commented 9 years ago
Update: Added some more nil checking to suppress errors, and a HideUIPanel():

-------------
function dataobj.OnClick(self, btn)
    if TourGuide.db.char.currentguide == "No Guide" then InterfaceOptionsFrame_OpenToFrame(TourGuide.guidespanel)
    else
        if btn == "RightButton" then
            if TourGuide.objectiveframe:IsVisible() then
                HideUIPanel(TourGuide.objectiveframe)
            else
                local quad, vhalf, hhalf = GetQuadrant(self)
                local anchpoint = (vhalf == "TOP" and "BOTTOM" or "TOP")..hhalf
                TourGuide.objectiveframe:ClearAllPoints()
                TourGuide.objectiveframe:SetPoint(quad, self, anchpoint)
                ShowUIPanel(TourGuide.objectiveframe)
            end
        else
            HideUIPanel(QuestLogFrame) --Hide the frame so it can select the current quest if in the log
            local i = TourGuide:GetQuestLogIndexByName()
            if i then SelectQuestLogEntry(i) end
            ShowUIPanel(QuestLogFrame)
            local qid = TourGuide:GetObjectiveTag("QID", nextstep) --This nil checks if the current the current objective does not have a QID objective tag
            if LightHeaded and qid then LightHeaded:UpdateFrame(qid) end --Added to fix a bug where one could not open the quest details with LightHeaded, with nil check so it will not throw an error if LightHeaded is not loaded
        end
    end
end
-----------------

Original comment by MikeNGoS...@gmail.com on 21 Sep 2008 at 6:27

GoogleCodeExporter commented 9 years ago
I still don't see why this is needed...

Original comment by Tekkub on 21 Sep 2008 at 7:04

GoogleCodeExporter commented 9 years ago
Tekkub, this is a feature I want for myself to be able to view a  quest's 
comments before picking it up. I already 
have changed my version to implement this, and I wish to make it known to you 
what I changed. If I like this 
functionally, maybe someone else will, too.

Original comment by MikeNGoS...@gmail.com on 22 Sep 2008 at 1:27