Lolcoincoin / tekkub-wow

Automatically exported from code.google.com/p/tekkub-wow
0 stars 0 forks source link

Level Feature suggestion #731

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I think a new Objective-Type Level 'l' for tourguide is a must in light of 
what tourguide is... "TourGuide is an interactive leveling guide addon."

A quick easy new Objective-Type Level 'l' objective could auto-complete - 
as opposed to Objective-Type Note (N You should be level 32 by now)
I started to add an Objective-Type Level 'l' ('L' is reserved for the Loot 
Tag type). 

The sample start code I started with is Below (The sample code is correct 
for English and German Clients). I figured the Level objectives could  
auto-complete directly in the Parser.lua local function ParseQuests(...)  
using the UnitLevel("player") API and in TourGuide:CHAT_MSG_SYSTEM(event, 
msg).

But this where I stopped becuase I also want to keep my code base 
compatable to yours so that I can continue to take advantage of updates - 
bug fixes - new features etc. (I also had no write acsess to your docs 
("How to edit TourGuide guides"). Lastly I realised that I'm surely not 
the only person who would profit from such a feature.

It would be great if you would add this Level Objective type to the 
Leveling framework!

Like I said I started addin like this (I'm a bottom up programmer)...

in locale.lua
    ["Congratulations, you have reached level (.*)!"] = "Glückwunsch! 
Ihr habt Stufe (.*) erreicht!",

in QuestTracking.lua
...
function TourGuide:CHAT_MSG_SYSTEM(event, msg)
...
-- or use the UnitLevel("player") API call
    local _, _, lvl = msg:find(L["Congratulations, you have reached 
level (.*)!"])
    if lvl then
        self:DebugF(1, "Detected levelup %d", lvl)
        self.db.char.level = loc
        return action == "LEVEL" and lvl >= quest and 
self:SetTurnedIn()
    end
...

Original issue reported on code.google.com by br...@rickersol.de on 1 Jan 2009 at 3:37

GoogleCodeExporter commented 9 years ago
Sorry bout the Type-Defect. I missed the other options on the form. This is not 
a 
Defect - it is a Suggestion/RFC.

Original comment by br...@rickersol.de on 1 Jan 2009 at 4:08

GoogleCodeExporter commented 9 years ago
TG used to have this, it was removed because it is not needed, and in many 
cases 
makes the guides worse.

Original comment by Tekkub on 1 Jan 2009 at 7:42

GoogleCodeExporter commented 9 years ago
OK. To cover Quest minimum levels and I can get what I want using a Note with a 
sub-
objective like this.

"N Mimumum Level: {0} Recommended Level: {1}|QO|Congratulations, you have 
reached 
level {0}!"

Original comment by br...@rickersol.de on 4 Jan 2009 at 11:15