Feature: allow the guide title to be different from the zone name

[GoogleCodeExporter]

Right now, the file format for a guide is like this:

TourGuide:RegisterGuide("Tanaris (47-48)", "Hinterlands (48)", "Alliance", 
function()
return [[

]]
end)

I've started doing my own guides and I want them to appear with a different 
name in the guide list. I did this:

TourGuide:RegisterGuide("Eric's Tanaris (47-48)", "Eric's Hinterlands 
(48)", "Alliance", function()
return [[

]]
end)

The problem with this is that TourGuide parse the words before the (level) 
and use this as the zone name for the coordinate. By using "Eric's 
Tanaris", I receive an error message saying that "Eric's Tanaris" is not a 
valid zone name and that the local zone will be used instead.

Can we have an extra parameter that would be the default zone for the data 
file. Something like:

TourGuide:RegisterGuide("Eric's Tanaris (47-48)", "Eric's Hinterlands 
(48)", "Alliance", "Tanaris", function()
return [[

]]
end)

My guess is that you could test to see if the forth parameter is a function 
or a string to know if the default zone has been provided.

TIA

Original issue reported on code.google.com by eric.bea...@gmail.com on 14 Jan 2009 at 11:35

[GoogleCodeExporter]

Would "[Eric's guides] Tanaris (47-48)" work?  I think it looks better myself.  
You 
can also just stick your extra text in the parens, they don't have to be a 
level 
range.

Original comment by Tekkub on 14 Jan 2009 at 11:42

[GoogleCodeExporter]

Well, having the [] would be OK I guess but I would prefer not having anything 
format dependent in the guide title.

Original comment by eric.bea...@gmail.com on 15 Jan 2009 at 1:15

[GoogleCodeExporter]

Hey Tekkub.

Right now the [] give an error message, would it be possible to get them not to?

Another question, would it be possible to make it so that the wow-pro guides 
appear a
tthe top of the list in-game? (only for people who installed my extra folder).

Since anyway what they want to use are my guides, it would be nice if I could 
make
them appear on top, so that they don't have to scroll all the way down the list 
to
find them.

-Jame

Original comment by Jame.wow...@gmail.com on 17 Jan 2009 at 12:58

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Currently alpha version has this if you wish to test.

Original comment by Tekkub on 21 Jan 2009 at 1:47

• Changed state: Fixed

[GoogleCodeExporter]

Definitely, I'll test it right away. Thank you for your answer.

Original comment by Jame.wow...@gmail.com on 21 Jan 2009 at 11:21

[GoogleCodeExporter]

Ok I just tested it.

First I need to make sure I downloaded the right alpha version.

I went here:

http://github.com/tekkub/tourguide/commit/5f69223e7370569ca7ec7b2968c6a48f7d7939
38

And downloaded the "master" file. Is that the correct alpha version? It has the
change to the parser.lua file you made. So I assumed it was the right file.

If it is the right file, the change doesn't work.

I tried a guide with the following code:

TourGuide:RegisterGuide("[Test] Elwynn Forest", nil, "Alliance", function()
return [[

At the first coordinates inserted in a note, I got this message:

TourGuide: No zone provided, using current zone.

Original comment by Jame.wow...@gmail.com on 21 Jan 2009 at 11:52

[GoogleCodeExporter]

Yes, that is the correct file.  You forgot the level range on the guide which 
is why 
it couldn't read it.

Original comment by Tekkub on 24 Jan 2009 at 9:29

[GoogleCodeExporter]

Ahh, indeed. I just tried again and it does work! Thank you.

One last question: when will this change be added to the official beta 
downloads,
like on wowinterface for example?

Original comment by Jame.wow...@gmail.com on 26 Jan 2009 at 12:11

[GoogleCodeExporter]

"Soon"

Original comment by Tekkub on 26 Jan 2009 at 12:53