Lolcroc / CraftingAutomat

A vanilla-flavoured autocrafter.
6 stars 9 forks source link

Issues with custom crafting recipes using tinkers construct and crafttweaker #30

Open secretmeister opened 1 year ago

secretmeister commented 1 year ago

With this recipe:

craftingTable.addShapeless("gravfast",*8, [,,,,,,,,.anyDamage().transformDamage(8)]);

The crafter has some very strange behavior. First off, you can put whatever sledge hammer you want in the crafting grid area itself, and it will be fine. However, to autocraft, it requires any FULL DURABILITY hammer in the input items area. further more, it will transform the input full durability hammer, into a further damaged by 8 version of the hammer in the center crafting part. So if you have 8 cobblestone and a wooden hammer damaged by 5 in the center, it will not craft until you put an undamaged hammer into the input slots, in which case it will craft, and then replace the input hammer with a wooden hammer damaged by 13. This can be exploited by putting a very expensive hammer in the crafting part and then converting cheap hammers, and is also very hard to actually use for these recipes. image image image

secretmeister commented 1 year ago

(The wooden hammer in the bottom row of the last picture has 208 durability)

secretmeister commented 1 year ago

1.18.2 is the version

Lolcroc commented 1 year ago

Thank you for your investigation! I am aware of this issue, in issue #14 something similar is happening. My mod is simply checking ingredients against the entry in the recipe book, but that’s not sufficient for these kinds of funny recipes. I’m not aware of an easy solution to fix this, but it’s on the roadmap for this mod (together with support for dynamic recipes, such as fireworks).

If you have some ideas about how to do this don’t hesitate to reply here.