LoliKingdom / Bansoukou

Bansōkō [絆創膏] - a simple coremod that streamlines patching of (most) mods
9 stars 3 forks source link

Some mods patched only after closing error window (Mod Duplicates) #4

Closed Krutoy242 closed 3 months ago

Krutoy242 commented 1 year ago

Reproduce

Steps i get into issue:

  1. I updated some mods
  2. Removed all -patched.jar files and renamed .disabled back to .jar

    This how my folder files looks like explorer_UJpy6f7dpg

  3. Next, i launched game and get this error:

    javaw_acEh9ctosn

  4. This how mods/ folder looks like when i see error above

    explorer_XZTZGfBLAk

  5. As soon as i close MC window with error above, files renamed

    image

  6. I launch game again and everything working fine

Even though I have about 20 mods modified through Bansoukou, only these two mods create the error: ImmersiveEngineering and BetterAnimalsPlus.

Logs

Logs that generated after step 5.: debug.zip

Versions

Rongmario commented 1 year ago

I'll take a look at both of those mods and see what's up, thanks.

Krutoy242 commented 1 year ago

Issue is still actual! More and more players hit this issue running E2EE

image

Rongmario commented 1 year ago

Got it, I'll probably have to rewrite -.-

Krutoy242 commented 7 months ago

Video demonstration of files renamed only after i'm closing MC window.

https://github.com/LoliKingdom/Bansoukou/assets/936618/4d5c0edb-1693-4c6e-8641-b9397f6014a4

Epikest commented 6 months ago

can confirm this issue still happens, happened to my buddy and i today while running E2EE. for me it got fixed while creating a new instance.

Rongmario commented 6 months ago

I'm currently developing version 5 which will address all of these issues. Please stay put thank you!

VladimirPlatun commented 4 months ago

Hi! I am facing the same problem, can I count on fixing this error?

Rongmario commented 3 months ago

Fixed in v5.