LoliKingdom / LoliASM

The lolis are now preparing to bytecode manipulate your game.
GNU Lesser General Public License v2.1
105 stars 22 forks source link

[Delegated to Blackbox] Animated Textures won't animate, such as Items, Fluids, etc. #113

Closed SonicX8000 closed 2 years ago

SonicX8000 commented 2 years ago

Prob a dupe issue but I dunno if item textures were mentioned.

Minecraft: 1.12.2 Forge: 14.23.5.2860

Optifine is NOT, installed.

Mods: 9 !mixinbooter-4.2 [MixinCompat-0.8] Baubles-1.12-1.5.2 Botania+r1.10-362 GottschCore-mc1.12.2-f14.23.5.2859-v1.15.0 HadEnoughItems_1.12.2-4.22.0 loliasm-5.3 Nyx-1.5.1 Treasure2-mc1.12.2-f14.23.5.2859-v2.0.1

Log: latest.log

Debug: debug.log


For some reason, some modded item textures won't animate at all and will remain static. I used the above mods as examples since they have animated item textures.

2022-06-03 20-28-47 The items won't animate if ASM is installed.

2022-06-03 20-34-06 The items will animate if ASM isn't installed.

If onDemandAnimatedTextures is set to false, the item textures will animate correctly. Also some other notes, I saw that some fluids inside the tinker smeltery were also static-like, though this also happened with the original Vanillafix mod.

They also remain static in the JEI / HEI Menu.

Exaxxion commented 2 years ago

Probably half of the recent reports are "Textures aren't animating with the setting that disables textures animations on" / "closed as duplicate of #109".

SonicX8000 commented 2 years ago

Yea, but I encountered this without having Optifine installed, and I dunno if they mentioned items having the issue along with the other stuff.

My apologies if this is a duplicated issue.

lesdmark commented 2 years ago

I am also having this issue. Currently happening in the GTCEu Port of Nomi. Noticed that the Nomicoins looked weird and investigated and found that all the content tweaker animated textures were frozen. turning off the setting mentioned in #109 fixes it.

Vetpetmon commented 2 years ago

[13:26:47] [Client thread/ERROR] [minecraft/TextureMap]: Using missing texture, unable to load minecraft:textures/textures/atlas/blocks.png.png, java.io.FileNotFoundException

A lot of files are trying to load .png.png

Rongmario commented 2 years ago

That sounds like a Thaumcraft issue.

Vetpetmon commented 2 years ago

UPDATE: We have a workaround.

Disable onDemandAnimatedTextures in your .cfg file. It's all the way down to the bottom of the file. The .png.png issue is not fixed, however. This could have some weird effects.

Rongmario commented 2 years ago

I mean, this was mentioned several times in this exact thread and on other issue threads.

Vetpetmon commented 2 years ago

Vanilla textures work just fine, modded (from any mod) don't.

Modded textures work just fine without this mod, when this mod is installed, they don't work. This includes fluids, block textures, item textures, and so on.

The .png.png errors only show up when LoliASM is installed.

I am testing this on v5.3, I will revert to v4.x until it's fixed

Another update: The workaround in #109 does not fix this.

Rongmario commented 2 years ago

I'll probably remove and delegate this feature to Blackbox. It's too invasive to get it fully working.

As for the extension doubling issue, I'll take a look still.

Rongmario commented 2 years ago

@Vetpetmon do you have logs for when you saw the duplicate .png suffix errors?

reddvilzz commented 1 year ago

Sorry to post on closed issue here, with the new update for the onDemandAnimatedTextures if optifine is used, it still need to be set to false?

Rongmario commented 1 year ago

Yes I believe so.

BinBashBanana commented 11 months ago

For those with optifine+*asm+foamfix, you may need to set enable=false under textures in foamfix.cfg if you are encountering extreme client tick lag with onDemandAnimatedTextures=false.