search

LoliKingdom / LoliASM

The lolis are now preparing to bytecode manipulate your game.
GNU Lesser General Public License v2.1
109 stars 23 forks source link

[Feature] Add Better crashes like Vanillafix #121

Open Armagedon13 opened 2 years ago

Armagedon13 commented 2 years ago

This can be a good feature because we can't use vanilla fix anymore with this mod, and some random crashes we need to open the pack again and that took so much time.

Vanillafix give this feautures

Better crashes:

Catch crashes, causing them to crash only the current world rather than the whole game Automatic identification of the mod(s) which caused a crash Offer to paste crash reports to https://paste.dimdev.org/ and give you a link to the syntax-highlighted crash report Stack traces get automatically deobfuscated in crash reports Crash reports contain more useful information, such as the NBT of a crashing entity/tile entity Add a warning notification which informs you about possible problems with your mods, which could cause more serious problems later on Disable the F3 + C delay and add Alt + F3 + C to crash the integrated server

Rongmario commented 2 years ago

This mod already adds this portion of VanillaFix.

Cephelo commented 2 years ago

I believe they're assuming that this mod doesn't have these features is because they're getting crashes that do not take them to a crash screen and then to the main menu. I've had a similar issue: https://discord.com/channels/926486493562814515/926486494032592896/997369224941027389 Rong already knows about this specific one, but I think the more info on the crashes failing to take the user to the crash screen, the better, that way it can be fixed.

@Armagedon13 Would you attach the crashes that are not taking you to the crash screen / main menu?

Armagedon13 commented 2 years ago

sorry @Rongmario i don't know this feature are available because i have a weird crash and didn't go to menu screen. this is the crash @throaway123869 https://justpaste.it/5moz4

Cephelo commented 2 years ago

Interesting, both my crash and yours are a java.util.ConcurrentModificationException, from an exception ticking something, and something about Nodes and HashMaps. Here is my crash for reference. crash-2022-06-28_19.23.54-server.txt Perhaps a look at the VanillaFix source code would be enlightening? Not sure though.