LoliKingdom / LoliASM

The lolis are now preparing to bytecode manipulate your game.
GNU Lesser General Public License v2.1
106 stars 23 forks source link

Sledgehammer, CensoredASM, Thaumcraft incompatibility? #163

Closed Keaft closed 1 year ago

Keaft commented 1 year ago

Crash Log: https://pastebin.com/L8gwxwyY

I'm a bit of a dunce when it comes to Mixin shenanigans, but I'm trying to make the switch in my modpack from VanillaFix to CensoredASM and it crashes on startup. If I remove Sledgehammer it boots just fine.

Let me know if you need more information! Thanks.

Keaft commented 1 year ago

It would appear that one config line in sledgehammer.cfg may have been the problem. Premature-culling must be set to false or it crashes. I assume CensoredASM handles this itself.


# If 'true', fixes MC-88176 (entities culled too aggresively at subchunk boundaries) and MC-72166 (banners invisible at some angles).
        premature-culling=false
Rongmario commented 1 year ago

Indeed @embeddedt fixes MC-88176 in this project with a more compatible patch for if you're using OptiFine.

Either disable premature-culling in sledgehammer.cfg or disable our fixMC88176.