search

LoliKingdom / LoliASM

The lolis are now preparing to bytecode manipulate your game.
GNU Lesser General Public License v2.1
109 stars 23 forks source link

potential bug with LAN multiplayer (The received string length is longer than maximum allowed (28 > 20)) #245

Closed mattrix444 closed 7 months ago

mattrix444 commented 7 months ago

Hi firstly i want to apologize if this isnt anything to do with loliasm but the reason i put it here is because its the only mod i can see mentioned in the logs so I'm not sure if its just informational or bug related. when i play with my son in LAN whoever isnt the host if they die they crash with this error and a bunch of network related logs and they cannot rejoin. latest.log again im sorry if your mod is unrelated

Rongmario commented 7 months ago

I had a look and while the crash isn't loliasm's fault, the problem could be quite hard to properly diagnose. Can you try to remove mods slowly and see when you stop crashing?

Some mods don't properly take into consideration of LAN mode, I recommend launching a dedicated server for you and your son to join. It doesn't take more resources than a normal LAN environment.

mattrix444 commented 7 months ago

i see, thank you for taking the time to look into it anyway, you're a gem. i had an inkling its something to do with the recent mojang username migration thing. people using email addresses that are super long are getting passed as usernames in game or something when some mods send packet data and its causing an error. again thank for looking at this. ill close this :)

Rongmario commented 7 months ago

Do give an update if you do find the cause, we will try to spend some time on this too.

mattrix444 commented 7 months ago

Hi, just wanted to let you know I eventually found out what it was. not sure what exactly what was happening but the mod called "Carian style" was the culprit. I went through all my mods and added them one by one until it crashed and its all fine now I've gotten rid of it.

Rongmario commented 7 months ago

Thanks! I'll try get in touch with the author or propose a fix over to UniversalTweaks.

mattrix444 commented 5 months ago

hi, just wanted to follow up and let you know the dev of carianstyle got back to me and has released a fix for various things including this issue. the source code is available so you can have a look at what was changed if you're curious :) thanks for the interest even though it wasn't your mod!

On Mon, 15 Apr 2024, 23:52 Rongmario, @.***> wrote:

I had a look and while the crash isn't loliasm's fault, the problem could be quite hard to properly diagnose. Can you try to remove mods slowly and see when you stop crashing?

Some mods don't properly take into consideration of LAN mode, I recommend launching a dedicated server for you and your son to join. It doesn't take more resources than a normal LAN environment.

— Reply to this email directly, view it on GitHub https://github.com/LoliKingdom/LoliASM/issues/245#issuecomment-2057943434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHRP6SRH2Y65JB324RKHR4LY5RK2HAVCNFSM6AAAAABGHDJWKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJXHE2DGNBTGQ . You are receiving this because you authored the thread.Message ID: @.***>